Fix "Set pages" drop crash by changing outside drags to simply add a new URL

Fix "Set pages" drop crash by changing outside drags to simply add a new URL
rather than attempt to re-order a list with no indexes selected.

R=arv@chromium.org
BUG=302284
TEST=browser_tests, manual (see bug)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231636

[arv (Not doing code reviews), 2013-10-29 13:48:03]

LGTM with nits

https://codereview.chromium.org/47033003/diff/110001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/startup_page_list_browsertest.js (right):

https://codereview.chromium.org/47033003/diff/110001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/startup_page_list_browsertest.js:28: /**
@protected */
protected seems strange but ok

https://codereview.chromium.org/47033003/diff/110001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/startup_page_list_browsertest.js:48: url:
'http://yahoo.com',
{
  key: value,
  ...
}

If the object literal does not fit on one line

https://codereview.chromium.org/47033003/diff/110001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/startup_page_list_browsertest.js:81: data_: {},
No storage on the prototype object please

https://codereview.chromium.org/47033003/diff/110001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/startup_page_list_browsertest.js:87: * @private
private does not seem correct. It is never called from within this "class". Is
it dead code?

If private use trailing underscore

https://codereview.chromium.org/47033003/diff/110001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/startup_page_list_browsertest.js:110: var event
= document.createEvent('MouseEvent');
Use 

new MouseEvent(type, {bubbles: true, cancelable: true})

https://codereview.chromium.org/47033003/diff/110001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/startup_page_list_browsertest.js:111:
event.initMouseEvent(type, true, true);
initMouseEvent has 15 (or some ridiculous number like that) parameters and they
are not optional.

https://codereview.chromium.org/47033003/diff/110001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/startup_page_list_browsertest.js:117: /** @const
*/ var newPage = 'http://google.com';
useless anotation

[Dan Beam, 2013-10-29 17:31:31]

https://codereview.chromium.org/47033003/diff/110001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/startup_page_list_browsertest.js (right):

https://codereview.chromium.org/47033003/diff/110001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/startup_page_list_browsertest.js:28: /**
@protected */
On 2013/10/29 13:48:03, arv wrote:
> protected seems strange but ok

Ack.

https://codereview.chromium.org/47033003/diff/110001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/startup_page_list_browsertest.js:48: url:
'http://yahoo.com',
On 2013/10/29 13:48:03, arv wrote:
> {
>   key: value,
>   ...
> }
> 
> If the object literal does not fit on one line

Done.

https://codereview.chromium.org/47033003/diff/110001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/startup_page_list_browsertest.js:81: data_: {},
On 2013/10/29 13:48:03, arv wrote:
> No storage on the prototype object please

Done.

https://codereview.chromium.org/47033003/diff/110001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/startup_page_list_browsertest.js:87: * @private
On 2013/10/29 13:48:03, arv wrote:
> private does not seem correct. It is never called from within this "class". Is
> it dead code?
> 
> If private use trailing underscore

spurious annotation removed

https://codereview.chromium.org/47033003/diff/110001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/startup_page_list_browsertest.js:110: var event
= document.createEvent('MouseEvent');
On 2013/10/29 13:48:03, arv wrote:
> Use 
> 
> new MouseEvent(type, {bubbles: true, cancelable: true})

Done.

https://codereview.chromium.org/47033003/diff/110001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/startup_page_list_browsertest.js:111:
event.initMouseEvent(type, true, true);
On 2013/10/29 13:48:03, arv wrote:
> initMouseEvent has 15 (or some ridiculous number like that) parameters and
they
> are not optional.

Ack.

https://codereview.chromium.org/47033003/diff/110001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/startup_page_list_browsertest.js:117: /** @const
*/ var newPage = 'http://google.com';
On 2013/10/29 13:48:03, arv wrote:
> useless anotation

technically all of these are useless without a compiler ;) but we do this quite
a few places

[commit-bot: I haz the power, 2013-10-29 17:38:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/47033003/220001

[arv (Not doing code reviews), 2013-10-29 19:51:20]

https://codereview.chromium.org/47033003/diff/110001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/startup_page_list_browsertest.js (right):

https://codereview.chromium.org/47033003/diff/110001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/startup_page_list_browsertest.js:117: /** @const
*/ var newPage = 'http://google.com';
On 2013/10/29 17:31:31, Dan Beam wrote:
> On 2013/10/29 13:48:03, arv wrote:
> > useless anotation
> 
> technically all of these are useless without a compiler ;) but we do this
quite
> a few places

Generally I do not see the point in consts for local variables but some people
like them.

https://codereview.chromium.org/47033003/diff/220001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/startup_page_list_browsertest.js (right):

https://codereview.chromium.org/47033003/diff/220001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/startup_page_list_browsertest.js:97: * @param
{*} val The data to set. Will be stingified.
stingy son of a parameter

[Dan Beam, 2013-10-29 20:56:06]

https://codereview.chromium.org/47033003/diff/220001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/startup_page_list_browsertest.js (right):

https://codereview.chromium.org/47033003/diff/220001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/startup_page_list_browsertest.js:97: * @param
{*} val The data to set. Will be stingified.
On 2013/10/29 19:51:21, arv wrote:
> stingy son of a parameter

They will literally be made into the artist "Sting".

[Dan Beam, 2013-10-29 20:57:54]

Committed patchset #3 manually as r231636 (presubmit successful).

[commit-bot: I haz the power, 2013-10-29 21:13:39]

Failed to trigger a try job on win_rel
HTTP Error 400: Bad Request