Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Side by Side Diff: chrome/browser/chromeos/file_system_provider/fileapi/buffering_file_stream_reader.h

Issue 470323003: [fsp] Improve performance for reading small chunks of data. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_CHROMEOS_FILE_SYSTEM_PROVIDER_FILEAPI_BUFFERING_FILE_STRE AM_READER_H_ 5 #ifndef CHROME_BROWSER_CHROMEOS_FILE_SYSTEM_PROVIDER_FILEAPI_BUFFERING_FILE_STRE AM_READER_H_
6 #define CHROME_BROWSER_CHROMEOS_FILE_SYSTEM_PROVIDER_FILEAPI_BUFFERING_FILE_STRE AM_READER_H_ 6 #define CHROME_BROWSER_CHROMEOS_FILE_SYSTEM_PROVIDER_FILEAPI_BUFFERING_FILE_STRE AM_READER_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
11 #include "base/memory/weak_ptr.h" 11 #include "base/memory/weak_ptr.h"
12 #include "storage/browser/blob/file_stream_reader.h" 12 #include "storage/browser/blob/file_stream_reader.h"
13 13
14 namespace net { 14 namespace net {
15 class IOBuffer; 15 class IOBuffer;
16 } // namespace net 16 } // namespace net
17 17
18 namespace chromeos { 18 namespace chromeos {
19 namespace file_system_provider { 19 namespace file_system_provider {
20 20
21 // Wraps the file stream reader implementation with a prefetching buffer. 21 // Wraps the file stream reader implementation with a prefetching buffer.
22 // Reads data from the internal file stream reader in chunks of size at least 22 // Reads data from the internal file stream reader in chunks of size at least
23 // |buffer_size| bytes (or less for the last chunk, because of EOF). 23 // |preloading_buffer_length| bytes (or less for the last chunk, because of
24 // EOF). Up to |max_bytes_to_read| of bytes can be requested in total.
24 // 25 //
25 // The underlying inner file stream reader *must not* return any values 26 // The underlying internal file stream reader *must not* return any values
26 // synchronously. Instead, results must be returned by a callback, including 27 // synchronously. Instead, results must be returned by a callback, including
27 // errors. 28 // errors.
28 class BufferingFileStreamReader : public storage::FileStreamReader { 29 class BufferingFileStreamReader : public storage::FileStreamReader {
29 public: 30 public:
30 BufferingFileStreamReader( 31 BufferingFileStreamReader(
31 scoped_ptr<storage::FileStreamReader> file_stream_reader, 32 scoped_ptr<storage::FileStreamReader> file_stream_reader,
32 int buffer_size); 33 int preloading_buffer_length,
34 int64 max_bytes_to_read);
33 35
34 virtual ~BufferingFileStreamReader(); 36 virtual ~BufferingFileStreamReader();
35 37
36 // storage::FileStreamReader overrides. 38 // storage::FileStreamReader overrides.
37 virtual int Read(net::IOBuffer* buf, 39 virtual int Read(net::IOBuffer* buf,
38 int buf_len, 40 int buf_len,
39 const net::CompletionCallback& callback) OVERRIDE; 41 const net::CompletionCallback& callback) OVERRIDE;
40 virtual int64 GetLength( 42 virtual int64 GetLength(
41 const net::Int64CompletionCallback& callback) OVERRIDE; 43 const net::Int64CompletionCallback& callback) OVERRIDE;
42 44
43 private: 45 private:
44 // Copies data from the preloading buffer and updates the internal iterator. 46 // Copies data from the preloading buffer and updates the internal iterator.
45 // Returns number of bytes successfully copied. 47 // Returns number of bytes successfully copied.
46 int CopyFromPreloadingBuffer(scoped_refptr<net::IOBuffer> buffer, 48 int CopyFromPreloadingBuffer(scoped_refptr<net::IOBuffer> buffer,
47 int buffer_length); 49 int buffer_length);
48 50
49 // Preloads data from the internal stream reader and calls the |callback|. 51 // Preloads data from the internal stream reader and calls the |callback|.
50 void Preload(const net::CompletionCallback& callback); 52 void Preload(const net::CompletionCallback& callback);
51 53
54 void OnReadCompleted(const net::CompletionCallback& callback, int result);
55
52 // Called when preloading of a buffer chunk is finished. Updates state of the 56 // Called when preloading of a buffer chunk is finished. Updates state of the
53 // preloading buffer and copied requested data to the |buffer|. 57 // preloading buffer and copied requested data to the |buffer|.
54 void OnPreloadCompleted(scoped_refptr<net::IOBuffer> buffer, 58 void OnPreloadCompleted(scoped_refptr<net::IOBuffer> buffer,
55 int buffer_length, 59 int buffer_length,
56 const net::CompletionCallback& callback, 60 const net::CompletionCallback& callback,
57 int result); 61 int result);
58 62
59 scoped_ptr<storage::FileStreamReader> file_stream_reader_; 63 scoped_ptr<storage::FileStreamReader> file_stream_reader_;
60 int buffer_size_; 64 int preloading_buffer_length_;
65 int64 max_bytes_to_read_;
66 int64 bytes_read_;
61 scoped_refptr<net::IOBuffer> preloading_buffer_; 67 scoped_refptr<net::IOBuffer> preloading_buffer_;
62 int preloading_buffer_offset_; 68 int preloading_buffer_offset_;
63 int buffered_bytes_; 69 int preloaded_bytes_;
64 70
65 base::WeakPtrFactory<BufferingFileStreamReader> weak_ptr_factory_; 71 base::WeakPtrFactory<BufferingFileStreamReader> weak_ptr_factory_;
66 DISALLOW_COPY_AND_ASSIGN(BufferingFileStreamReader); 72 DISALLOW_COPY_AND_ASSIGN(BufferingFileStreamReader);
67 }; 73 };
68 74
69 } // namespace file_system_provider 75 } // namespace file_system_provider
70 } // namespace chromeos 76 } // namespace chromeos
71 77
72 #endif // CHROME_BROWSER_CHROMEOS_FILE_SYSTEM_PROVIDER_FILEAPI_BUFFERING_FILE_S TREAM_READER_H_ 78 #endif // CHROME_BROWSER_CHROMEOS_FILE_SYSTEM_PROVIDER_FILEAPI_BUFFERING_FILE_S TREAM_READER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698