Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 470313003: Revert of HelpApp cut at M38: manifest.json (Closed)

Created:
6 years, 4 months ago by cylee1
Modified:
6 years, 4 months ago
CC:
chromium-reviews, n.s.buttar
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of HelpApp cut at M38: manifest.json (patchset #3 of https://codereview.chromium.org/474223002/) Reason for revert: According to Dmitry, we should not use persistent background page. Original issue's description: > HelpApp cut at M38: manifest.json > > BUG=chromium:404093 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290245 TBR=cnwan@google.com,dpolukhin@google.com,nkostylev@chromium.org,dpolukhin@chromium.org NOTREECHECKS=true NOTRY=true BUG=chromium:404093 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290524

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M chrome/browser/resources/help_app/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/help_app/manifest.json View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
cylee1
Created Revert of HelpApp cut at M38: manifest.json
6 years, 4 months ago (2014-08-19 09:22:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cylee@chromium.org/470313003/1
6 years, 4 months ago (2014-08-19 09:22:55 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-19 09:22:57 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-19 09:22:58 UTC) #4
cylee1
Hi Dmitry, committer approval needed. thanks.
6 years, 4 months ago (2014-08-19 09:23:49 UTC) #5
Dmitry Polukhin
lgtm
6 years, 4 months ago (2014-08-19 09:24:22 UTC) #6
cylee1
The CQ bit was checked by cylee@chromium.org
6 years, 4 months ago (2014-08-19 09:28:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cylee@chromium.org/470313003/1
6 years, 4 months ago (2014-08-19 09:30:11 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-19 09:31:48 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (1) as 290524

Powered by Google App Engine
This is Rietveld 408576698