Fix bug in CPDF_PageContentGenerate constructor and destructor

Fix bug in CPDF_PageContentGenerate constructor and destructor

m_pageObjects never gets initialize, thus making CPDF_PageContentGenerate::GenerateContent() doing nothing.

Since the CPFD_PageObject are owned by m_pPage, no need to release them in the destructor.

BUG=385119
R=thestig@chromium.org, vitalybuka@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/93d0811

[Bo Xu, 2014-08-19 23:35:28]

Hi Vitaly, Lei, please review this.

Also, in
https://code.google.com/p/chromium/codesearch#chromium/src/pdf/pdfium/pdfium_...

line 1074,  FPDF_PAGEOBJECT img_obj = FPDFPageObj_NewImgeObj(output_doc); does
not look right. Should it be FPDF_PAGEOBJECT img_obj =
FPDFPageObj_NewImgeObj(temp_doc);

Although this does not affect the result.

[Lei Zhang, 2014-08-20 00:04:22]

lgtm

https://codereview.chromium.org/470253004/diff/1/core/src/fpdfapi/fpdf_edit/f...
File core/src/fpdfapi/fpdf_edit/fpdf_edit_content.cpp (right):

https://codereview.chromium.org/470253004/diff/1/core/src/fpdfapi/fpdf_edit/f...
core/src/fpdfapi/fpdf_edit/fpdf_edit_content.cpp:25: if (CPDF_PageObject*
pPageObj = pPage->GetNextObject(pos)) {
Do you need the if statement? InsertPageObject() checks to see if |pPageObj| is
NULL.

[Vitaly Buka (NO REVIEWS), 2014-08-20 00:05:10]

lgtm

On 2014/08/19 23:35:28, Bo Xu wrote:
> Hi Vitaly, Lei, please review this.
> 
> Also, in
>
https://code.google.com/p/chromium/codesearch#chromium/src/pdf/pdfium/pdfium_...
> 
> line 1074,  FPDF_PAGEOBJECT img_obj = FPDFPageObj_NewImgeObj(output_doc); does
> not look right. Should it be FPDF_PAGEOBJECT img_obj =
> FPDFPageObj_NewImgeObj(temp_doc);
> 
> Although this does not affect the result.

I'll update this code.

[Bo Xu, 2014-08-20 00:16:57]

https://codereview.chromium.org/470253004/diff/1/core/src/fpdfapi/fpdf_edit/f...
File core/src/fpdfapi/fpdf_edit/fpdf_edit_content.cpp (right):

https://codereview.chromium.org/470253004/diff/1/core/src/fpdfapi/fpdf_edit/f...
core/src/fpdfapi/fpdf_edit/fpdf_edit_content.cpp:25: if (CPDF_PageObject*
pPageObj = pPage->GetNextObject(pos)) {
On 2014/08/20 00:04:22, Lei Zhang wrote:
> Do you need the if statement? InsertPageObject() checks to see if |pPageObj|
is
> NULL.

Right, it's not needed.

[Bo Xu, 2014-08-20 00:17:52]

Committed patchset #2 manually as 93d0811 (presubmit successful).