Source/bindings/templates/methods.cpp - Issue 47023015: IDL compiler: [Default] arguments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/methods.cpp

Issue 47023015: IDL compiler: [Default] arguments (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Revised Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/templates/methods.cpp

diff --git a/Source/bindings/templates/methods.cpp b/Source/bindings/templates/methods.cpp

index 7ea9ce8092fa7242a1229419e3ec68cc4b320d80..1d8c574e54d87521d9a33654211b51238645b271 100644

--- a/Source/bindings/templates/methods.cpp

+++ b/Source/bindings/templates/methods.cpp

@@ -10,7 +10,7 @@ static void {{method.name}}Method(const v8::FunctionCallbackInfo<v8::Value>& arg

{% endif %}

{{cpp_class_name}}* imp = {{v8_class_name}}::toNative(args.Holder());

{% for argument in method.arguments %}

- {% if argument.is_optional %}

+ {% if argument.is_optional and not argument.has_default %}

if (UNLIKELY(args.Length() <= {{argument.index}})) {

{{argument.cpp_method}};

return;