Avoid pre-aging when debugger is active

Avoid pre-aging when debugger is active

BUG=None
R=bmeurer@chromium.org

Committed: http://code.google.com/p/v8/source/detail?r=17443

[rmcilroy, 2013-10-29 12:33:26]

PTAL.

[Benedikt Meurer, 2013-10-29 12:38:06]

https://codereview.chromium.org/47023003/diff/1/src/arm/macro-assembler-arm.cc
File src/arm/macro-assembler-arm.cc (right):

https://codereview.chromium.org/47023003/diff/1/src/arm/macro-assembler-arm.c...
src/arm/macro-assembler-arm.cc:931: !isolate()->IsDebuggerActive()) {
Please add a new method to Isolate to determine whether code aging is enabled,
i.e. Isolate::IsCodeAgingActive().

[rmcilroy, 2013-10-29 12:40:55]

https://codereview.chromium.org/47023003/diff/1/src/arm/macro-assembler-arm.cc
File src/arm/macro-assembler-arm.cc (right):

https://codereview.chromium.org/47023003/diff/1/src/arm/macro-assembler-arm.c...
src/arm/macro-assembler-arm.cc:931: !isolate()->IsDebuggerActive()) {
On 2013/10/29 12:38:06, Benedikt Meurer wrote:
> Please add a new method to Isolate to determine whether code aging is enabled,
> i.e. Isolate::IsCodeAgingActive().

Do you mean a new method to IsCodePreAgingActive()? (IsCodeAgingActive is true
if FLAG_age_code, it is the pre-aging that needs more checks)?

[Benedikt Meurer, 2013-10-29 12:42:05]

On 2013/10/29 12:40:55, rmcilroy wrote:
> https://codereview.chromium.org/47023003/diff/1/src/arm/macro-assembler-arm.cc
> File src/arm/macro-assembler-arm.cc (right):
> 
>
https://codereview.chromium.org/47023003/diff/1/src/arm/macro-assembler-arm.c...
> src/arm/macro-assembler-arm.cc:931: !isolate()->IsDebuggerActive()) {
> On 2013/10/29 12:38:06, Benedikt Meurer wrote:
> > Please add a new method to Isolate to determine whether code aging is
enabled,
> > i.e. Isolate::IsCodeAgingActive().
> 
> Do you mean a new method to IsCodePreAgingActive()? (IsCodeAgingActive is true
> if FLAG_age_code, it is the pre-aging that needs more checks)?

Yes. Just a method to encapsulate the sequence of checks that is currently
duplicated for every architecture. IsCodePreAgingActive() sounds good.

[rmcilroy, 2013-10-29 14:06:01]

https://codereview.chromium.org/47023003/diff/1/src/arm/macro-assembler-arm.cc
File src/arm/macro-assembler-arm.cc (right):

https://codereview.chromium.org/47023003/diff/1/src/arm/macro-assembler-arm.c...
src/arm/macro-assembler-arm.cc:931: !isolate()->IsDebuggerActive()) {
On 2013/10/29 12:40:55, rmcilroy wrote:
> On 2013/10/29 12:38:06, Benedikt Meurer wrote:
> > Please add a new method to Isolate to determine whether code aging is
enabled,
> > i.e. Isolate::IsCodeAgingActive().
> 
> Do you mean a new method to IsCodePreAgingActive()? (IsCodeAgingActive is true
> if FLAG_age_code, it is the pre-aging that needs more checks)?

Sounds good. Done.

[Benedikt Meurer, 2013-10-29 14:06:38]

On 2013/10/29 14:06:01, rmcilroy wrote:
> https://codereview.chromium.org/47023003/diff/1/src/arm/macro-assembler-arm.cc
> File src/arm/macro-assembler-arm.cc (right):
> 
>
https://codereview.chromium.org/47023003/diff/1/src/arm/macro-assembler-arm.c...
> src/arm/macro-assembler-arm.cc:931: !isolate()->IsDebuggerActive()) {
> On 2013/10/29 12:40:55, rmcilroy wrote:
> > On 2013/10/29 12:38:06, Benedikt Meurer wrote:
> > > Please add a new method to Isolate to determine whether code aging is
> enabled,
> > > i.e. Isolate::IsCodeAgingActive().
> > 
> > Do you mean a new method to IsCodePreAgingActive()? (IsCodeAgingActive is
true
> > if FLAG_age_code, it is the pre-aging that needs more checks)?
> 
> Sounds good. Done.

LGTM

[rmcilroy, 2013-10-29 16:04:15]

On 2013/10/29 14:06:38, Benedikt Meurer wrote:
> On 2013/10/29 14:06:01, rmcilroy wrote:
> >
https://codereview.chromium.org/47023003/diff/1/src/arm/macro-assembler-arm.cc
> > File src/arm/macro-assembler-arm.cc (right):
> > 
> >
>
https://codereview.chromium.org/47023003/diff/1/src/arm/macro-assembler-arm.c...
> > src/arm/macro-assembler-arm.cc:931: !isolate()->IsDebuggerActive()) {
> > On 2013/10/29 12:40:55, rmcilroy wrote:
> > > On 2013/10/29 12:38:06, Benedikt Meurer wrote:
> > > > Please add a new method to Isolate to determine whether code aging is
> > enabled,
> > > > i.e. Isolate::IsCodeAgingActive().
> > > 
> > > Do you mean a new method to IsCodePreAgingActive()? (IsCodeAgingActive is
> true
> > > if FLAG_age_code, it is the pre-aging that needs more checks)?
> > 
> > Sounds good. Done.
> 
> LGTM

Thanks Benedikt.  Could you land for me please.

[Jakob Kummerow, 2013-10-31 11:43:32]

Committed patchset #2 manually as r17443.