Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 470213002: Moving all the incident reporting stuff to a common folder (Closed)

Created:
6 years, 4 months ago by pmonette
Modified:
6 years, 4 months ago
Reviewers:
robertshield, mattm
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@binsign
Project:
chromium
Visibility:
Public.

Description

Moving all the incident reporting stuff to a common folder BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289938

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -5708 lines) Patch
D chrome/browser/safe_browsing/add_incident_callback.h View 1 chunk +0 lines, -22 lines 0 comments Download
D chrome/browser/safe_browsing/binary_integrity_analyzer.h View 1 chunk +0 lines, -32 lines 0 comments Download
D chrome/browser/safe_browsing/binary_integrity_analyzer.cc View 1 chunk +0 lines, -93 lines 0 comments Download
D chrome/browser/safe_browsing/binary_integrity_analyzer_win.cc View 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/browser/safe_browsing/binary_integrity_analyzer_win_unittest.cc View 1 chunk +0 lines, -134 lines 0 comments Download
D chrome/browser/safe_browsing/binary_integrity_incident_handlers.h View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/browser/safe_browsing/binary_integrity_incident_handlers.cc View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/browser/safe_browsing/binary_integrity_incident_handlers_unittest.cc View 1 chunk +0 lines, -68 lines 0 comments Download
D chrome/browser/safe_browsing/delayed_analysis_callback.h View 1 chunk +0 lines, -22 lines 0 comments Download
D chrome/browser/safe_browsing/delayed_callback_runner.h View 1 chunk +0 lines, -66 lines 0 comments Download
D chrome/browser/safe_browsing/delayed_callback_runner.cc View 1 chunk +0 lines, -51 lines 0 comments Download
D chrome/browser/safe_browsing/delayed_callback_runner_unittest.cc View 1 chunk +0 lines, -160 lines 0 comments Download
D chrome/browser/safe_browsing/environment_data_collection.h View 1 chunk +0 lines, -18 lines 0 comments Download
D chrome/browser/safe_browsing/environment_data_collection.cc View 1 chunk +0 lines, -94 lines 0 comments Download
D chrome/browser/safe_browsing/environment_data_collection_win.h View 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/browser/safe_browsing/environment_data_collection_win.cc View 1 chunk +0 lines, -151 lines 0 comments Download
D chrome/browser/safe_browsing/environment_data_collection_win_unittest.cc View 1 chunk +0 lines, -218 lines 0 comments Download
D chrome/browser/safe_browsing/incident_handler_util.h View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/browser/safe_browsing/incident_handler_util.cc View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/browser/safe_browsing/incident_report_uploader.h View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/browser/safe_browsing/incident_report_uploader.cc View 1 chunk +0 lines, -16 lines 0 comments Download
D chrome/browser/safe_browsing/incident_report_uploader_impl.h View 1 chunk +0 lines, -71 lines 0 comments Download
D chrome/browser/safe_browsing/incident_report_uploader_impl.cc View 1 chunk +0 lines, -99 lines 0 comments Download
D chrome/browser/safe_browsing/incident_report_uploader_impl_unittest.cc View 1 chunk +0 lines, -72 lines 0 comments Download
A + chrome/browser/safe_browsing/incident_reporting/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/safe_browsing/incident_reporting/add_incident_callback.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_win.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/safe_browsing/incident_reporting/binary_integrity_incident_handlers.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/safe_browsing/incident_reporting/binary_integrity_incident_handlers.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/safe_browsing/incident_reporting/binary_integrity_incident_handlers_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/safe_browsing/incident_reporting/delayed_analysis_callback.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/safe_browsing/incident_reporting/delayed_callback_runner.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/safe_browsing/incident_reporting/delayed_callback_runner.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/safe_browsing/incident_reporting/delayed_callback_runner_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/safe_browsing/incident_reporting/environment_data_collection.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/safe_browsing/incident_reporting/environment_data_collection.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/safe_browsing/incident_reporting/incident_handler_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/safe_browsing/incident_reporting/incident_handler_util.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/safe_browsing/incident_reporting/incident_report_uploader.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/safe_browsing/incident_reporting/incident_report_uploader.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/safe_browsing/incident_reporting/incident_report_uploader_impl.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/safe_browsing/incident_reporting/incident_report_uploader_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/safe_browsing/incident_reporting/incident_report_uploader_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.h View 3 chunks +8 lines, -8 lines 0 comments Download
A + chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc View 2 chunks +6 lines, -6 lines 0 comments Download
A + chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/safe_browsing/incident_reporting/last_download_finder.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/safe_browsing/incident_reporting/module_integrity_unittest_util_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/safe_browsing/incident_reporting/module_integrity_unittest_util_win.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/safe_browsing/incident_reporting/module_integrity_verifier_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/safe_browsing/incident_reporting/module_integrity_verifier_win.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/safe_browsing/incident_reporting/module_integrity_verifier_win_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/safe_browsing/incident_reporting/tracked_preference_incident_handlers.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/safe_browsing/incident_reporting/tracked_preference_incident_handlers.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/safe_browsing/incident_reporting/tracked_preference_incident_handlers_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/safe_browsing/incident_reporting_service.h View 1 chunk +0 lines, -316 lines 0 comments Download
D chrome/browser/safe_browsing/incident_reporting_service.cc View 1 chunk +0 lines, -954 lines 0 comments Download
D chrome/browser/safe_browsing/incident_reporting_service_unittest.cc View 1 chunk +0 lines, -898 lines 0 comments Download
D chrome/browser/safe_browsing/last_download_finder.h View 1 chunk +0 lines, -117 lines 0 comments Download
D chrome/browser/safe_browsing/last_download_finder.cc View 1 chunk +0 lines, -257 lines 0 comments Download
D chrome/browser/safe_browsing/last_download_finder_unittest.cc View 1 chunk +0 lines, -331 lines 0 comments Download
D chrome/browser/safe_browsing/module_integrity_unittest_util_win.h View 1 chunk +0 lines, -23 lines 0 comments Download
D chrome/browser/safe_browsing/module_integrity_unittest_util_win.cc View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/browser/safe_browsing/module_integrity_verifier_win.h View 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/browser/safe_browsing/module_integrity_verifier_win.cc View 1 chunk +0 lines, -298 lines 0 comments Download
D chrome/browser/safe_browsing/module_integrity_verifier_win_unittest.cc View 1 chunk +0 lines, -154 lines 0 comments Download
D chrome/browser/safe_browsing/preference_validation_delegate.h View 1 chunk +0 lines, -45 lines 0 comments Download
D chrome/browser/safe_browsing/preference_validation_delegate.cc View 1 chunk +0 lines, -93 lines 0 comments Download
D chrome/browser/safe_browsing/preference_validation_delegate_unittest.cc View 1 chunk +0 lines, -279 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/browser/safe_browsing/tracked_preference_incident_handlers.h View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/browser/safe_browsing/tracked_preference_incident_handlers.cc View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/browser/safe_browsing/tracked_preference_incident_handlers_unittest.cc View 1 chunk +0 lines, -63 lines 0 comments Download
M chrome/chrome_browser.gypi View 3 chunks +29 lines, -29 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
pmonette_google.com
PTAL
6 years, 4 months ago (2014-08-14 21:01:30 UTC) #1
pmonette_google.com
There is a bug fix in environment_data_collection_win_unittest.cc where the module ref count was incremented with ...
6 years, 4 months ago (2014-08-14 21:03:44 UTC) #2
robertshield
Sorry for the bother but could you do the bug fix in a separate CL? ...
6 years, 4 months ago (2014-08-14 21:06:08 UTC) #3
pmonette_google.com
You are right. I have done it now so this CL is only about moving/renaming ...
6 years, 4 months ago (2014-08-14 21:41:21 UTC) #4
mattm
lgtm
6 years, 4 months ago (2014-08-14 22:26:19 UTC) #5
robertshield
The CQ bit was checked by robertshield@chromium.org
6 years, 4 months ago (2014-08-15 13:53:27 UTC) #6
robertshield
lgtm
6 years, 4 months ago (2014-08-15 13:53:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pmonette@google.com/470213002/40001
6 years, 4 months ago (2014-08-15 13:55:54 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 18:15:43 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (40001) as 289938

Powered by Google App Engine
This is Rietveld 408576698