Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 470193002: Set keyboard height to 0 before show a keyboard in a different extension (Closed)

Created:
6 years, 4 months ago by bshe
Modified:
6 years, 4 months ago
Reviewers:
Shu Chen, kevers
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Set keyboard height to 0 before show a keyboard in a different extension This keeps the UX the same as Android. As a side effect, it also fix issue 403789. Korea keyboard is in a different extension and has a different keyboard height compare to US keyboard. Before this CL, at lock screen, user see a white keyboard area that is of korean keyboard height at first, then after US keyboard loaded, the white area shrink to a smaller size and the US keyboard finally shows up. After this CL, we wont see a white rectangle keyboard area and the US keyboard only comes up after loaded. BUG=403789 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289704

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M ui/keyboard/keyboard_controller_proxy.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
bshe
Hi Kevin. Do you mind to take a look at this? Thanks! I will add ...
6 years, 4 months ago (2014-08-14 15:54:00 UTC) #1
kevers
lgtm
6 years, 4 months ago (2014-08-14 16:31:00 UTC) #2
bshe
The CQ bit was checked by bshe@chromium.org
6 years, 4 months ago (2014-08-14 16:31:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bshe@chromium.org/470193002/1
6 years, 4 months ago (2014-08-14 16:32:43 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel_swarming on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-14 20:22:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (1) as 289704
6 years, 4 months ago (2014-08-14 21:35:19 UTC) #6
Shu Chen
This cl caused a regression that when the focus is not in an input field, ...
6 years, 4 months ago (2014-08-16 02:22:20 UTC) #7
Shu Chen
6 years, 4 months ago (2014-08-16 02:25:47 UTC) #8
Message was sent while issue was closed.
crbug.com/404340 is opened for the regression.

Powered by Google App Engine
This is Rietveld 408576698