Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 470133003: Remove restriction on x64 chromium linker builds. (Closed)

Created:
6 years, 4 months ago by simonb (inactive)
Modified:
6 years, 4 months ago
Reviewers:
Nico, rmcilroy
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove restriction on x64 chromium linker builds. As of r287591 the android chromium linker supports EM_X86_64 and x86_64 relocations. Remove the restriction preventing libchromium_android_linker.so building when arch=x64. BUG=369133 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289683

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M base/base.gyp View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
simonb (inactive)
6 years, 4 months ago (2014-08-14 14:45:57 UTC) #1
rmcilroy
On 2014/08/14 14:45:57, simonb wrote: lgtm, but you will need an lgmt from an owner.
6 years, 4 months ago (2014-08-14 15:01:00 UTC) #2
simonb (inactive)
thakis@, please lgtm for base. Thanks.
6 years, 4 months ago (2014-08-14 15:17:12 UTC) #3
Nico
lgtm
6 years, 4 months ago (2014-08-14 15:20:50 UTC) #4
simonb (inactive)
The CQ bit was checked by simonb@chromium.org
6 years, 4 months ago (2014-08-14 15:40:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonb@chromium.org/470133003/1
6 years, 4 months ago (2014-08-14 15:42:47 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 20:07:39 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (1) as 289683

Powered by Google App Engine
This is Rietveld 408576698