Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: athena/wm/window_manager_impl.cc

Issue 470083004: athena: A simpler implementation of WindowListProvider. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: athena/wm/window_manager_impl.cc
diff --git a/athena/wm/window_manager_impl.cc b/athena/wm/window_manager_impl.cc
index f1243115d42b1465a93e37a1bc647298df755cdd..2aee0622765ad17764d240a822c7a44b14c914c0 100644
--- a/athena/wm/window_manager_impl.cc
+++ b/athena/wm/window_manager_impl.cc
@@ -10,10 +10,10 @@
#include "athena/input/public/accelerator_manager.h"
#include "athena/screen/public/screen_manager.h"
#include "athena/wm/bezel_controller.h"
-#include "athena/wm/mru_window_tracker.h"
#include "athena/wm/public/window_manager_observer.h"
#include "athena/wm/split_view_controller.h"
#include "athena/wm/title_drag_controller.h"
+#include "athena/wm/window_list_provider_impl.h"
#include "athena/wm/window_overview_mode.h"
#include "base/logging.h"
#include "base/observer_list.h"
@@ -79,7 +79,7 @@ class WindowManagerImpl : public WindowManager,
virtual void OnTitleDragCanceled(aura::Window* window) OVERRIDE;
scoped_ptr<aura::Window> container_;
- scoped_ptr<MruWindowTracker> mru_window_tracker_;
+ scoped_ptr<WindowListProvider> window_list_provider_;
scoped_ptr<WindowOverviewMode> overview_;
scoped_ptr<BezelController> bezel_controller_;
scoped_ptr<SplitViewController> split_view_controller_;
@@ -118,10 +118,10 @@ WindowManagerImpl::WindowManagerImpl() {
container_.reset(ScreenManager::Get()->CreateDefaultContainer(params));
container_->SetLayoutManager(new AthenaContainerLayoutManager);
container_->AddObserver(this);
- mru_window_tracker_.reset(new MruWindowTracker(container_.get()));
+ window_list_provider_.reset(new WindowListProviderImpl(container_.get()));
bezel_controller_.reset(new BezelController(container_.get()));
split_view_controller_.reset(new SplitViewController(
- container_.get(), mru_window_tracker_.get(), this));
+ container_.get(), window_list_provider_.get(), this));
bezel_controller_->set_left_right_delegate(split_view_controller_.get());
container_->AddPreTargetHandler(bezel_controller_.get());
title_drag_controller_.reset(new TitleDragController(container_.get(), this));
@@ -136,7 +136,7 @@ WindowManagerImpl::WindowManagerImpl() {
WindowManagerImpl::~WindowManagerImpl() {
overview_.reset();
split_view_controller_.reset();
- mru_window_tracker_.reset();
+ window_list_provider_.reset();
if (container_) {
container_->RemoveObserver(this);
container_->RemovePreTargetHandler(bezel_controller_.get());
@@ -176,13 +176,13 @@ void WindowManagerImpl::SetInOverview(bool active) {
if (active) {
FOR_EACH_OBSERVER(WindowManagerObserver, observers_,
OnOverviewModeEnter());
- // Re-stack all windows in the order defined by mru_window_tracker_.
- aura::Window::Windows window_list = mru_window_tracker_->GetWindowList();
+ // Re-stack all windows in the order defined by window_list_provider_.
+ aura::Window::Windows window_list = window_list_provider_->GetWindowList();
aura::Window::Windows::iterator it;
for (it = window_list.begin(); it != window_list.end(); ++it)
container_->StackChildAtTop(*it);
overview_ = WindowOverviewMode::Create(container_.get(),
- mru_window_tracker_.get(),
+ window_list_provider_.get(),
this);
} else {
overview_.reset();
@@ -209,7 +209,7 @@ void WindowManagerImpl::RemoveObserver(WindowManagerObserver* observer) {
}
void WindowManagerImpl::OnSelectWindow(aura::Window* window) {
- mru_window_tracker_->MoveToFront(window);
+ window_list_provider_->MoveToFront(window);
wm::ActivateWindow(window);
SetInOverview(false);
}

Powered by Google App Engine
This is Rietveld 408576698