Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: athena/wm/window_list_provider_impl_unittest.cc

Issue 470083004: athena: A simpler implementation of WindowListProvider. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « athena/wm/window_list_provider_impl.cc ('k') | athena/wm/window_manager_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: athena/wm/window_list_provider_impl_unittest.cc
diff --git a/athena/wm/window_list_provider_impl_unittest.cc b/athena/wm/window_list_provider_impl_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..eba6b7a9ca58fd446860e4ff0261850d429f44ca
--- /dev/null
+++ b/athena/wm/window_list_provider_impl_unittest.cc
@@ -0,0 +1,86 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "athena/wm/window_list_provider_impl.h"
+
+#include <algorithm>
+
+#include "athena/test/athena_test_base.h"
+#include "ui/aura/test/test_window_delegate.h"
+#include "ui/aura/window.h"
+
+namespace athena {
+
+namespace {
+
+bool AreWindowListsEqual(const aura::Window::Windows& one,
+ const aura::Window::Windows& two) {
+ return one.size() == two.size() &&
+ std::equal(one.begin(), one.end(), two.begin());
+}
+
+scoped_ptr<aura::Window> CreateWindow(aura::WindowDelegate* delegate,
+ ui::wm::WindowType window_type) {
+ scoped_ptr<aura::Window> window(new aura::Window(delegate));
+ window->SetType(window_type);
+ window->Init(aura::WINDOW_LAYER_SOLID_COLOR);
+ return window.Pass();
+}
+
+} // namespace
+
+typedef test::AthenaTestBase WindowListProviderImplTest;
+
+// Tests that the order of windows match the stacking order of the windows in
+// the container, even after the order is changed through the aura Window API.
+TEST_F(WindowListProviderImplTest, StackingOrder) {
+ aura::test::TestWindowDelegate delegate;
+ scoped_ptr<aura::Window> container(new aura::Window(&delegate));
+ scoped_ptr<aura::Window> first =
+ CreateWindow(&delegate, ui::wm::WINDOW_TYPE_NORMAL);
+ scoped_ptr<aura::Window> second =
+ CreateWindow(&delegate, ui::wm::WINDOW_TYPE_NORMAL);
+ scoped_ptr<aura::Window> third =
+ CreateWindow(&delegate, ui::wm::WINDOW_TYPE_NORMAL);
+ container->AddChild(first.get());
+ container->AddChild(second.get());
+ container->AddChild(third.get());
+
+ scoped_ptr<WindowListProvider> list_provider(
+ new WindowListProviderImpl(container.get()));
+ EXPECT_TRUE(AreWindowListsEqual(container->children(),
+ list_provider->GetWindowList()));
+
+ container->StackChildAtTop(first.get());
+ EXPECT_TRUE(AreWindowListsEqual(container->children(),
+ list_provider->GetWindowList()));
+ EXPECT_EQ(first.get(), container->children().back());
+}
+
+TEST_F(WindowListProviderImplTest, ListContainsOnlyNormalWindows) {
+ aura::test::TestWindowDelegate delegate;
+ scoped_ptr<aura::Window> container(new aura::Window(&delegate));
+ scoped_ptr<aura::Window> first =
+ CreateWindow(&delegate, ui::wm::WINDOW_TYPE_NORMAL);
+ scoped_ptr<aura::Window> second =
+ CreateWindow(&delegate, ui::wm::WINDOW_TYPE_POPUP);
+ scoped_ptr<aura::Window> third =
+ CreateWindow(&delegate, ui::wm::WINDOW_TYPE_NORMAL);
+ scoped_ptr<aura::Window> fourth =
+ CreateWindow(&delegate, ui::wm::WINDOW_TYPE_MENU);
+ container->AddChild(first.get());
+ container->AddChild(second.get());
+ container->AddChild(third.get());
+ container->AddChild(fourth.get());
+
+ scoped_ptr<WindowListProvider> list_provider(
+ new WindowListProviderImpl(container.get()));
+ const aura::Window::Windows list = list_provider->GetWindowList();
+ EXPECT_EQ(list.end(), std::find(list.begin(), list.end(), second.get()));
+ EXPECT_EQ(list.end(), std::find(list.begin(), list.end(), fourth.get()));
+ EXPECT_NE(list.end(), std::find(list.begin(), list.end(), first.get()));
+ EXPECT_NE(list.end(), std::find(list.begin(), list.end(), third.get()));
+}
+
+} // namespace athena
« no previous file with comments | « athena/wm/window_list_provider_impl.cc ('k') | athena/wm/window_manager_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698