Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(930)

Issue 470063008: Bound everything except drawText(). (Closed)

Created:
6 years, 4 months ago by mtklein_C
Modified:
6 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Bound everything except drawText(). BUG=skia: Committed: https://skia.googlesource.com/skia/+/131a22b2a22e4656f2351d42785fc3dee7a98fe2

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2

Patch Set 3 : DrawTextOnPath #

Patch Set 4 : right #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -12 lines) Patch
M src/core/SkRecordDraw.cpp View 1 2 3 4 chunks +53 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
mtklein
6 years, 4 months ago (2014-08-25 20:56:59 UTC) #1
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 4 months ago (2014-08-25 20:57:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/470063008/20001
6 years, 4 months ago (2014-08-25 20:57:27 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 4 months ago (2014-08-25 20:57:28 UTC) #4
robertphillips
The CQ bit was unchecked by robertphillips@google.com
6 years, 4 months ago (2014-08-25 21:00:30 UTC) #5
robertphillips
lgtm + question https://codereview.chromium.org/470063008/diff/20001/src/core/SkRecordDraw.cpp File src/core/SkRecordDraw.cpp (right): https://codereview.chromium.org/470063008/diff/20001/src/core/SkRecordDraw.cpp#newcode358 src/core/SkRecordDraw.cpp:358: SkRect dst = op.path.getBounds(); B.c. we ...
6 years, 4 months ago (2014-08-25 21:00:40 UTC) #6
f(malita)
lgtm
6 years, 4 months ago (2014-08-25 21:03:23 UTC) #7
mtklein
https://codereview.chromium.org/470063008/diff/20001/src/core/SkRecordDraw.cpp File src/core/SkRecordDraw.cpp (right): https://codereview.chromium.org/470063008/diff/20001/src/core/SkRecordDraw.cpp#newcode358 src/core/SkRecordDraw.cpp:358: SkRect dst = op.path.getBounds(); On 2014/08/25 21:00:40, robertphillips wrote: ...
6 years, 4 months ago (2014-08-25 21:09:22 UTC) #8
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 4 months ago (2014-08-25 21:09:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/470063008/60001
6 years, 4 months ago (2014-08-25 21:09:33 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-25 21:16:20 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 (60001) as 131a22b2a22e4656f2351d42785fc3dee7a98fe2

Powered by Google App Engine
This is Rietveld 408576698