Source/bindings/scripts/v8_methods.py - Issue 470063003: IDL: Use IdlArrayOrSequenceType for array/sequence IDL types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_methods.py

Issue 470063003: IDL: Use IdlArrayOrSequenceType for array/sequence IDL types (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@idl-extend-IdlTypeBase

Patch Set: simplify cpp_type_has_null_value() Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_methods.py

diff --git a/Source/bindings/scripts/v8_methods.py b/Source/bindings/scripts/v8_methods.py

index 0365ec08fd13db1b8de666b3535087557ce21e89..c69fcd1f3bec6af9e2d387395ce9e368fa0ed1a7 100644

--- a/Source/bindings/scripts/v8_methods.py

+++ b/Source/bindings/scripts/v8_methods.py

@@ -54,7 +54,7 @@ CUSTOM_REGISTRATION_EXTENDED_ATTRIBUTES = frozenset([

def argument_needs_try_catch(argument, return_promise):

idl_type = argument.idl_type

- base_type = not idl_type.native_array_element_type and idl_type.base_type

+ base_type = idl_type.base_type

return not (

# These cases are handled by separate code paths in the

@@ -234,7 +234,7 @@ def argument_context(interface, method, argument, index):

has_extended_attribute_value(method, 'TypeChecking', 'Unrestricted')) and

idl_type.name in ('Float', 'Double'),

# Dictionary is special-cased, but arrays and sequences shouldn't be

- 'idl_type': not idl_type.native_array_element_type and idl_type.base_type,

+ 'idl_type': idl_type.base_type,

'idl_type_object': idl_type,

'index': index,

'is_clamp': 'Clamp' in extended_attributes,

« no previous file with comments | « Source/bindings/scripts/v8_dictionary.py ('k') | Source/bindings/scripts/v8_types.py » ('j') | no next file with comments »