Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Side by Side Diff: Source/bindings/templates/attributes.cpp

Issue 470063003: IDL: Use IdlArrayOrSequenceType for array/sequence IDL types (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@idl-extend-IdlTypeBase
Patch Set: simplify cpp_type_has_null_value() Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/scripts/v8_types.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 {##############################################################################} 1 {##############################################################################}
2 {% macro attribute_getter(attribute, world_suffix) %} 2 {% macro attribute_getter(attribute, world_suffix) %}
3 {% filter conditional(attribute.conditional_string) %} 3 {% filter conditional(attribute.conditional_string) %}
4 static void {{attribute.name}}AttributeGetter{{world_suffix}}( 4 static void {{attribute.name}}AttributeGetter{{world_suffix}}(
5 {%- if attribute.is_expose_js_accessors %} 5 {%- if attribute.is_expose_js_accessors %}
6 const v8::FunctionCallbackInfo<v8::Value>& info 6 const v8::FunctionCallbackInfo<v8::Value>& info
7 {%- else %} 7 {%- else %}
8 const v8::PropertyCallbackInfo<v8::Value>& info 8 const v8::PropertyCallbackInfo<v8::Value>& info
9 {%- endif %}) 9 {%- endif %})
10 { 10 {
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 if (isNull) { 78 if (isNull) {
79 v8SetReturnValueNull(info); 79 v8SetReturnValueNull(info);
80 return; 80 return;
81 } 81 }
82 {% endif %} 82 {% endif %}
83 {% if attribute.cached_attribute_validation_method %} 83 {% if attribute.cached_attribute_validation_method %}
84 V8HiddenValue::setHiddenValue(info.GetIsolate(), holder, propertyName, {{att ribute.cpp_value_to_v8_value}}); 84 V8HiddenValue::setHiddenValue(info.GetIsolate(), holder, propertyName, {{att ribute.cpp_value_to_v8_value}});
85 {% endif %} 85 {% endif %}
86 {# v8SetReturnValue #} 86 {# v8SetReturnValue #}
87 {% if attribute.is_keep_alive_for_gc %} 87 {% if attribute.is_keep_alive_for_gc %}
88 if ({{attribute.cpp_value}} && DOMDataStore::setReturnValueFromWrapper{{worl d_suffix}}<{{attribute.v8_type}}>(info.GetReturnValue(), {{attribute.cpp_value}} .get())) 88 if ({{attribute.cpp_value}} && DOMDataStore::setReturnValueFromWrapper{{worl d_suffix}}<V8{{attribute.idl_type}}>(info.GetReturnValue(), {{attribute.cpp_valu e}}.get()))
89 return; 89 return;
90 v8::Handle<v8::Value> wrapper = toV8({{attribute.cpp_value}}.get(), holder, info.GetIsolate()); 90 v8::Handle<v8::Value> wrapper = toV8({{attribute.cpp_value}}.get(), holder, info.GetIsolate());
91 if (!wrapper.IsEmpty()) { 91 if (!wrapper.IsEmpty()) {
92 V8HiddenValue::setHiddenValue(info.GetIsolate(), holder, v8AtomicString( info.GetIsolate(), "{{attribute.name}}"), wrapper); 92 V8HiddenValue::setHiddenValue(info.GetIsolate(), holder, v8AtomicString( info.GetIsolate(), "{{attribute.name}}"), wrapper);
93 {{attribute.v8_set_return_value}}; 93 {{attribute.v8_set_return_value}};
94 } 94 }
95 {% elif world_suffix %} 95 {% elif world_suffix %}
96 {{attribute.v8_set_return_value_for_main_world}}; 96 {{attribute.v8_set_return_value_for_main_world}};
97 {% else %} 97 {% else %}
98 {{attribute.v8_set_return_value}}; 98 {{attribute.v8_set_return_value}};
(...skipping 301 matching lines...) Expand 10 before | Expand all | Expand 10 after
400 if (!PrivateScriptRunner::rethrowExceptionInPrivateScript(scriptState->i solate(), exceptionState, block)) { 400 if (!PrivateScriptRunner::rethrowExceptionInPrivateScript(scriptState->i solate(), exceptionState, block)) {
401 // FIXME: We should support more exceptions. 401 // FIXME: We should support more exceptions.
402 RELEASE_ASSERT_NOT_REACHED(); 402 RELEASE_ASSERT_NOT_REACHED();
403 } 403 }
404 block.ReThrow(); 404 block.ReThrow();
405 return false; 405 return false;
406 } 406 }
407 return true; 407 return true;
408 } 408 }
409 {% endmacro %} 409 {% endmacro %}
OLDNEW
« no previous file with comments | « Source/bindings/scripts/v8_types.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698