Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2452)

Unified Diff: chrome/browser/renderer_host/resource_message_filter_gtk.cc

Issue 47002: Handle null window references.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/renderer_host/resource_message_filter_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/renderer_host/resource_message_filter_gtk.cc
===================================================================
--- chrome/browser/renderer_host/resource_message_filter_gtk.cc (revision 12186)
+++ chrome/browser/renderer_host/resource_message_filter_gtk.cc (working copy)
@@ -6,8 +6,16 @@
#include <gtk/gtk.h>
+// We get null window_ids passed into the two functions below; please see
+// http://crbug.com/9060 for more details.
+
void ResourceMessageFilter::OnGetWindowRect(gfx::NativeViewId window_id,
gfx::Rect* rect) {
+ if (!window_id) {
+ *rect = gfx::Rect();
+ return;
+ }
+
// Ideally this would be gtk_widget_get_window but that's only
// from gtk 2.14 onwards. :(
GdkWindow* window = gfx::NativeViewFromId(window_id)->window;
« no previous file with comments | « no previous file | chrome/browser/renderer_host/resource_message_filter_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698