Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: net/http/http_cache_unittest.cc

Issue 469993008: Rename Chromium-Resource-Freshness header (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_cache_transaction.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_cache_unittest.cc
diff --git a/net/http/http_cache_unittest.cc b/net/http/http_cache_unittest.cc
index bbd604416de26b81b4a40ac2c6441c0bc00b47a6..4987c37b025a6aa89f8279586e4b811ba6ad9c30 100644
--- a/net/http/http_cache_unittest.cc
+++ b/net/http/http_cache_unittest.cc
@@ -6730,14 +6730,12 @@ static void CheckResourceFreshnessHeader(const net::HttpRequestInfo* request,
std::string* response_headers,
std::string* response_data) {
std::string value;
- EXPECT_TRUE(
- request->extra_headers.GetHeader("Chromium-Resource-Freshness", &value));
+ EXPECT_TRUE(request->extra_headers.GetHeader("Resource-Freshness", &value));
EXPECT_EQ("max-age=3600,stale-while-revalidate=7200,age=10801", value);
}
-// Verify that the Chromium-Resource-Freshness header is sent on a revalidation
-// if the stale-while-revalidate directive was on the response.
-// TODO(ricea): Rename this test when a final name for the header is decided.
+// Verify that the Resource-Freshness header is sent on a revalidation if the
+// stale-while-revalidate directive was on the response.
TEST(HttpCache, ResourceFreshnessHeaderSent) {
MockHttpCache cache;
@@ -6753,8 +6751,7 @@ TEST(HttpCache, ResourceFreshnessHeaderSent) {
EXPECT_EQ(1, cache.network_layer()->transaction_count());
- // Send the request again and check that Chromium-Resource-Freshness header is
- // added.
+ // Send the request again and check that Resource-Freshness header is added.
stale_while_revalidate_transaction.handler = CheckResourceFreshnessHeader;
RunTransactionTest(cache.http_cache(), stale_while_revalidate_transaction);
@@ -6766,10 +6763,10 @@ static void CheckResourceFreshnessAbsent(const net::HttpRequestInfo* request,
std::string* response_status,
std::string* response_headers,
std::string* response_data) {
- EXPECT_FALSE(request->extra_headers.HasHeader("Chromium-Resource-Freshness"));
+ EXPECT_FALSE(request->extra_headers.HasHeader("Resource-Freshness"));
}
-// Verify that the Chromium-Resource-Freshness header is not sent when
+// Verify that the Resource-Freshness header is not sent when
// stale-while-revalidate is 0.
TEST(HttpCache, ResourceFreshnessHeaderNotSent) {
MockHttpCache cache;
@@ -6786,8 +6783,7 @@ TEST(HttpCache, ResourceFreshnessHeaderNotSent) {
EXPECT_EQ(1, cache.network_layer()->transaction_count());
- // Send the request again and check that Chromium-Resource-Freshness header is
- // absent.
+ // Send the request again and check that Resource-Freshness header is absent.
stale_while_revalidate_transaction.handler = CheckResourceFreshnessAbsent;
RunTransactionTest(cache.http_cache(), stale_while_revalidate_transaction);
« no previous file with comments | « net/http/http_cache_transaction.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698