chrome/browser/extensions/crx_installer_browsertest.cc - Issue 469993006: Use a qualified path for chromium_strings, google_chrome_strings, and generated_resources.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/crx_installer_browsertest.cc

Issue 469993006: Use a qualified path for chromium_strings, google_chrome_strings, and generated_resources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/crx_installer.cc ('k') | chrome/browser/extensions/dev_mode_bubble_controller.cc » ('j') | chrome/browser/password_manager/password_manager_util_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/crx_installer_browsertest.cc

diff --git a/chrome/browser/extensions/crx_installer_browsertest.cc b/chrome/browser/extensions/crx_installer_browsertest.cc

index aeb7313a007b71bf1e19f58b7e0775153508ff9f..57bd18f9a41512a71590105412d8121545169923 100644

--- a/chrome/browser/extensions/crx_installer_browsertest.cc

+++ b/chrome/browser/extensions/crx_installer_browsertest.cc

@@ -17,6 +17,7 @@

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_window.h"

#include "chrome/browser/ui/tabs/tab_strip_model.h"

+#include "chrome/grit/generated_resources.h"

#include "chrome/test/base/ui_test_utils.h"

#include "content/public/browser/browser_thread.h"

#include "content/public/browser/download_manager.h"

@@ -32,7 +33,6 @@

#include "extensions/common/file_util.h"

#include "extensions/common/permissions/permission_set.h"

#include "extensions/common/switches.h"

-#include "grit/generated_resources.h"

#include "ui/base/l10n/l10n_util.h"

#if defined(OS_CHROMEOS)