chrome/browser/renderer_context_menu/render_view_context_menu.cc - Issue 469993006: Use a qualified path for chromium_strings, google_chrome_strings, and generated_resources.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_context_menu/render_view_context_menu.cc

Issue 469993006: Use a qualified path for chromium_strings, google_chrome_strings, and generated_resources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/profiles/profiles_state.cc ('k') | chrome/browser/renderer_context_menu/spellchecker_submenu_observer_hunspell.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_context_menu/render_view_context_menu.cc

diff --git a/chrome/browser/renderer_context_menu/render_view_context_menu.cc b/chrome/browser/renderer_context_menu/render_view_context_menu.cc

index a3610e2bdf311c542a3698e78655e07acd5472de..91f02b8ec33070c6f8dd2baa030be583dac5fd33 100644

--- a/chrome/browser/renderer_context_menu/render_view_context_menu.cc

+++ b/chrome/browser/renderer_context_menu/render_view_context_menu.cc

@@ -60,6 +60,7 @@

#include "chrome/common/render_messages.h"

#include "chrome/common/spellcheck_messages.h"

#include "chrome/common/url_constants.h"

+#include "chrome/grit/generated_resources.h"

#include "components/google/core/browser/google_util.h"

#include "components/metrics/proto/omnibox_input_type.pb.h"

#include "components/omnibox/autocomplete_match.h"

@@ -89,7 +90,6 @@

#include "extensions/browser/extension_system.h"

#include "extensions/browser/view_type_utils.h"

#include "extensions/common/extension.h"

-#include "grit/generated_resources.h"

#include "net/base/escape.h"

#include "third_party/WebKit/public/web/WebContextMenuData.h"

#include "third_party/WebKit/public/web/WebMediaPlayerAction.h"