chrome/browser/extensions/sandboxed_unpacker.cc - Issue 469993006: Use a qualified path for chromium_strings, google_chrome_strings, and generated_resources.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/sandboxed_unpacker.cc

Issue 469993006: Use a qualified path for chromium_strings, google_chrome_strings, and generated_resources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/requirements_checker_browsertest.cc ('k') | chrome/browser/extensions/settings_api_bubble_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/sandboxed_unpacker.cc

diff --git a/chrome/browser/extensions/sandboxed_unpacker.cc b/chrome/browser/extensions/sandboxed_unpacker.cc

index 05fef3b06648976b3b1dec3c3a1ee49ec7a75bc6..56e51180a1d8f57a1a9bdf1a3d4356050f88f9c9 100644

--- a/chrome/browser/extensions/sandboxed_unpacker.cc

+++ b/chrome/browser/extensions/sandboxed_unpacker.cc

@@ -26,6 +26,7 @@

#include "chrome/common/chrome_utility_messages.h"

#include "chrome/common/extensions/chrome_utility_extensions_messages.h"

#include "chrome/common/extensions/extension_file_util.h"

+#include "chrome/grit/generated_resources.h"

#include "components/crx_file/constants.h"

#include "components/crx_file/crx_file.h"

#include "components/crx_file/id_util.h"

@@ -39,7 +40,6 @@

#include "extensions/common/file_util.h"

#include "extensions/common/manifest_constants.h"

#include "extensions/common/manifest_handlers/icons_handler.h"

-#include "grit/generated_resources.h"

#include "third_party/skia/include/core/SkBitmap.h"

#include "ui/base/l10n/l10n_util.h"

#include "ui/gfx/codec/png_codec.h"