chrome/browser/extensions/extension_uninstall_dialog.cc - Issue 469993006: Use a qualified path for chromium_strings, google_chrome_strings, and generated_resources.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_uninstall_dialog.cc

Issue 469993006: Use a qualified path for chromium_strings, google_chrome_strings, and generated_resources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_storage_monitor.cc ('k') | chrome/browser/extensions/extension_warning_badge_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_uninstall_dialog.cc

diff --git a/chrome/browser/extensions/extension_uninstall_dialog.cc b/chrome/browser/extensions/extension_uninstall_dialog.cc

index 16bfe22be95554cb79c31392f97627e39169633f..735f95354c7ba67d60c4bac4b2f78f8f150ebd98 100644

--- a/chrome/browser/extensions/extension_uninstall_dialog.cc

+++ b/chrome/browser/extensions/extension_uninstall_dialog.cc

@@ -10,6 +10,7 @@

#include "base/strings/utf_string_conversions.h"

#include "chrome/browser/extensions/extension_util.h"

#include "chrome/browser/profiles/profile.h"

+#include "chrome/grit/generated_resources.h"

#include "extensions/browser/extension_registry.h"

#include "extensions/browser/image_loader.h"

#include "extensions/common/constants.h"

@@ -17,7 +18,6 @@

#include "extensions/common/extension_icon_set.h"

#include "extensions/common/extension_resource.h"

#include "extensions/common/manifest_handlers/icons_handler.h"

-#include "grit/generated_resources.h"

#include "grit/theme_resources.h"

#include "ui/base/l10n/l10n_util.h"

#include "ui/gfx/image/image.h"