chrome/browser/extensions/requirements_checker.cc - Issue 469993006: Use a qualified path for chromium_strings, google_chrome_strings, and generated_resources.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/requirements_checker.cc

Issue 469993006: Use a qualified path for chromium_strings, google_chrome_strings, and generated_resources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/extensions/proxy_overridden_bubble_controller.cc ('k') | chrome/browser/extensions/requirements_checker_browsertest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/extensions/requirements_checker.h"	5 #include "chrome/browser/extensions/requirements_checker.h"

6	6

7 #include "base/bind.h"	7 #include "base/bind.h"

8 #include "chrome/browser/gpu/gpu_feature_checker.h"	8 #include "chrome/browser/gpu/gpu_feature_checker.h"

	9 #include "chrome/grit/generated_resources.h"

9 #include "content/public/browser/browser_thread.h"	10 #include "content/public/browser/browser_thread.h"

10 #include "extensions/common/extension.h"	11 #include "extensions/common/extension.h"

11 #include "extensions/common/manifest.h"	12 #include "extensions/common/manifest.h"

12 #include "extensions/common/manifest_handlers/requirements_info.h"	13 #include "extensions/common/manifest_handlers/requirements_info.h"

13 #include "gpu/config/gpu_feature_type.h"	14 #include "gpu/config/gpu_feature_type.h"

14 #include "grit/generated_resources.h"

15 #include "ui/base/l10n/l10n_util.h"	15 #include "ui/base/l10n/l10n_util.h"

16	16

17 #if defined(OS_WIN)	17 #if defined(OS_WIN)

18 #include "base/win/metro.h"	18 #include "base/win/metro.h"

19 #endif	19 #endif

20	20

21 namespace extensions {	21 namespace extensions {

22	22

23 RequirementsChecker::RequirementsChecker()	23 RequirementsChecker::RequirementsChecker()

24 : pending_requirement_checks_(0) {	24 : pending_requirement_checks_(0) {

(...skipping 63 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
88 if (--pending_requirement_checks_ == 0) {	88 if (--pending_requirement_checks_ == 0) {

89 content::BrowserThread::PostTask(content::BrowserThread::UI, FROM_HERE,	89 content::BrowserThread::PostTask(content::BrowserThread::UI, FROM_HERE,

90 base::Bind(callback_, errors_));	90 base::Bind(callback_, errors_));

91 // Reset the callback so any ref-counted bound parameters will get released.	91 // Reset the callback so any ref-counted bound parameters will get released.

92 callback_.Reset();	92 callback_.Reset();

93 errors_.clear();	93 errors_.clear();

94 }	94 }

95 }	95 }

96	96

97 } // namespace extensions	97 } // namespace extensions

OLD	NEW