chrome/browser/extensions/pack_extension_job.cc - Issue 469993006: Use a qualified path for chromium_strings, google_chrome_strings, and generated_resources.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/pack_extension_job.cc

Issue 469993006: Use a qualified path for chromium_strings, google_chrome_strings, and generated_resources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/extensions/ntp_overridden_bubble_controller.cc ('k') | chrome/browser/extensions/proxy_overridden_bubble_controller.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/extensions/pack_extension_job.h"	5 #include "chrome/browser/extensions/pack_extension_job.h"

6	6

7 #include "base/bind.h"	7 #include "base/bind.h"

8 #include "base/message_loop/message_loop.h"	8 #include "base/message_loop/message_loop.h"

9 #include "base/strings/sys_string_conversions.h"	9 #include "base/strings/sys_string_conversions.h"

10 #include "base/strings/utf_string_conversions.h"	10 #include "base/strings/utf_string_conversions.h"

11 #include "chrome/browser/extensions/extension_creator.h"	11 #include "chrome/browser/extensions/extension_creator.h"

	12 #include "chrome/grit/generated_resources.h"

12 #include "extensions/common/constants.h"	13 #include "extensions/common/constants.h"

13 #include "grit/generated_resources.h"

14 #include "ui/base/l10n/l10n_util.h"	14 #include "ui/base/l10n/l10n_util.h"

15	15

16 using content::BrowserThread;	16 using content::BrowserThread;

17	17

18 namespace extensions {	18 namespace extensions {

19	19

20 PackExtensionJob::PackExtensionJob(Client* client,	20 PackExtensionJob::PackExtensionJob(Client* client,

21 const base::FilePath& root_directory,	21 const base::FilePath& root_directory,

22 const base::FilePath& key_file,	22 const base::FilePath& key_file,

23 int run_flags)	23 int run_flags)

(...skipping 77 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
101 crx_file_string);	101 crx_file_string);

102 } else {	102 } else {

103 return l10n_util::GetStringFUTF16(	103 return l10n_util::GetStringFUTF16(

104 IDS_EXTENSION_PACK_DIALOG_SUCCESS_BODY_NEW,	104 IDS_EXTENSION_PACK_DIALOG_SUCCESS_BODY_NEW,

105 crx_file_string,	105 crx_file_string,

106 key_file_string);	106 key_file_string);

107 }	107 }

108 }	108 }

109	109

110 } // namespace extensions	110 } // namespace extensions

OLD	NEW