Issue 469993004: w3c deps roll for layout tests: copy stale expectations downstream.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 469993004: w3c deps roll for layout tests: copy stale expectations downstream. (Closed)

Created:
6 years, 4 months ago by Dirk Pranke

Modified:
6 years, 4 months ago

Reviewers:
phoglund_chromium

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

w3c deps roll for layout tests: copy stale expectations downstream. This copies any TestExpectations that refer to tests that no longer exist or no longer fail at tip-of-tree in the w3c repos from Blink to Chromium, so that we can safely roll to the new revisions. This is patch 2 of 6 in the roll. TBR=phoglund@chromium.org BUG=404022 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289885

Patch Set 1 #

Patch Set 2 : add more failing tests #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	webkit/tools/layout_tests/test_expectations_w3c.txt	View	1	1 chunk	+9 lines, -1 line	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/469993004/20001

6 years, 4 months ago (2014-08-15 02:51:18 UTC) #3

phoglund_chromium

lgtm https://codereview.chromium.org/469993004/diff/20001/webkit/tools/layout_tests/test_expectations_w3c.txt File webkit/tools/layout_tests/test_expectations_w3c.txt (right): https://codereview.chromium.org/469993004/diff/20001/webkit/tools/layout_tests/test_expectations_w3c.txt#newcode10 webkit/tools/layout_tests/test_expectations_w3c.txt:10: crbug.com/330083 w3c/web-platform-tests/shadow-dom/shadow-trees/distributed-pseudo-element/test-001.html [ Failure ] Nit: remove tab

6 years, 4 months ago (2014-08-15 09:23:53 UTC) #4

commit-bot: I haz the power

6 years, 4 months ago (2014-08-15 15:59:26 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (20001) as 289885

Expand Messages | Collapse Messages