Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4906)

Unified Diff: chrome/common/extensions/api/app_window.idl

Issue 469993003: Add AppWindow.setVisibleOnAllWorkspaces. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sync and rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/app_window.idl
diff --git a/chrome/common/extensions/api/app_window.idl b/chrome/common/extensions/api/app_window.idl
index caff663e29def5edda094f0f520ba3571bbe3072..2029f2c5d097fb636335d9aee81d218dc5ac4807 100644
--- a/chrome/common/extensions/api/app_window.idl
+++ b/chrome/common/extensions/api/app_window.idl
@@ -263,6 +263,9 @@ namespace app.window {
// If true, the window will be focused when created. Defaults to true.
boolean? focused;
+
+ // If true, the window will be visible on all workspaces.
benwells 2014/08/20 05:02:08 You should mention that this is only available in
jackhou1 2014/08/27 05:10:45 Done.
+ boolean? visibleOnAllWorkspaces;
};
// Called in the creating window (parent) before the load event is called in
@@ -369,6 +372,14 @@ namespace app.window {
// TODO(jackhou): Document this properly before going to stable.
[nodoc] static boolean alphaEnabled();
+ // For platforms that support multiple workspaces, is this window on all of
+ // them?
+ [nodoc] static void setVisibleOnAllWorkspaces(boolean alwaysVisible);
benwells 2014/08/20 05:02:08 Can you remove the [nodoc] and mention that this i
jackhou1 2014/08/27 05:10:45 Done.
+
+ // Does the current platform support windows being visible on all
+ // workspaces?
+ [nodoc] static boolean canSetVisibleOnAllWorkspaces();
benwells 2014/08/20 05:02:08 I just realised this is on the AppWindow. Can we j
jackhou1 2014/08/27 05:10:45 Done.
+
// The JavaScript 'window' object for the created child.
[instanceOf=Window] object contentWindow;

Powered by Google App Engine
This is Rietveld 408576698