chrome/browser/apps/app_window_browsertest.cc - Issue 469993003: Add AppWindow.setVisibleOnAllWorkspaces.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/apps/app_window_browsertest.cc

Issue 469993003: Add AppWindow.setVisibleOnAllWorkspaces. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Sync and rebase Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « apps/ui/views/native_app_window_views.cc ('k') | chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.h » ('j') | chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "apps/app_window_geometry_cache.h"	5 #include "apps/app_window_geometry_cache.h"

6 #include "chrome/browser/apps/app_browsertest_util.h"	6 #include "chrome/browser/apps/app_browsertest_util.h"

7 #include "chrome/browser/extensions/extension_test_message_listener.h"	7 #include "chrome/browser/extensions/extension_test_message_listener.h"

8 #include "chrome/browser/profiles/profile.h"	8 #include "chrome/browser/profiles/profile.h"

9 #include "chrome/browser/ui/browser.h"	9 #include "chrome/browser/ui/browser.h"

10 #include "chrome/browser/ui/extensions/application_launch.h"	10 #include "chrome/browser/ui/extensions/application_launch.h"

(...skipping 239 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
250 }	250 }

251	251

252 // TODO(benwells): Remove this test once all the things are merged together. It	252 // TODO(benwells): Remove this test once all the things are merged together. It

253 // is currently present as this feature was previously disabled on stable	253 // is currently present as this feature was previously disabled on stable

254 // channel, so the test is to ensure it has all been re-enabled properly.	254 // channel, so the test is to ensure it has all been re-enabled properly.

255 IN_PROC_BROWSER_TEST_F(AppWindowAPITest, TestFrameColorsInStable) {	255 IN_PROC_BROWSER_TEST_F(AppWindowAPITest, TestFrameColorsInStable) {

256 extensions::ScopedCurrentChannel channel(chrome::VersionInfo::CHANNEL_STABLE);	256 extensions::ScopedCurrentChannel channel(chrome::VersionInfo::CHANNEL_STABLE);

257 ASSERT_TRUE(RunAppWindowAPITest("testFrameColors")) << message_;	257 ASSERT_TRUE(RunAppWindowAPITest("testFrameColors")) << message_;

258 }	258 }

259 #endif	259 #endif

	260
	benwells 2014/08/20 05:02:08 We should test that it is limited to dev channel. We should test that it is limited to dev channel. jackhou1 2014/08/27 05:10:45 Done. Show quoted text On 2014/08/20 05:02:08, benwells wrote: > We should test that it is limited to dev channel. Done.
	261 IN_PROC_BROWSER_TEST_F(AppWindowAPITest, TestVisibleOnAllWorkspaces) {

	262 ASSERT_TRUE(

	263 RunAppWindowAPITestAndWaitForRoundTrip("testVisibleOnAllWorkspaces"))

	264 << message_;

	265 }

OLD	NEW