Issue 469973002: Emit .local before .comm to make llvm-mc happy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 469973002: Emit .local before .comm to make llvm-mc happy. (Closed)

Created:
6 years, 4 months ago by jvoung (off chromium)

Modified:
6 years, 4 months ago

Reviewers:
Jim Stichnoth

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Visibility:
Public.

Emit .local before .comm for bss to make llvm-mc happy. Otherwise llvm-mc asserts. This is also the order that llc emits the directives. Change a couple of RUIN -> RUN in lit tests. BUG=none R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=f820da5

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -18 lines)			Patch
M	src/IceTargetLoweringX8632.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	tests_lit/llvm2ice_tests/convert.ll	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	tests_lit/llvm2ice_tests/globalinit.pnacl.ll	View	6 chunks	+11 lines, -5 lines	0 comments	Download
M	tests_lit/llvm2ice_tests/nacl-atomic-fence-all.ll	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests_lit/llvm2ice_tests/shift.ll	View	1 chunk	+4 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

jvoung (off chromium)

6 years, 4 months ago (2014-08-14 15:20:53 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as f820da5 (presubmit successful).