Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 469943003: TestPlugin to chromium c++ style. (Closed)

Created:
6 years, 4 months ago by Abhishek
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

TestPlugin to chromium c++ style. Changes: 1) Run clang-format through source and header files. 2) Rename data member variables to use unix_hacker_ style. 3) Rename methods to use CamelCase style. 4) Rename file name to test_plugin. BUG=331299 Committed: https://crrev.com/dd9554f3fb936060ee3db0912b1ada9bf33e2c60 Cr-Commit-Position: refs/heads/master@{#293160}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+944 lines, -849 lines) Patch
M content/content_shell.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
D content/shell/renderer/test_runner/TestPlugin.h View 1 chunk +0 lines, -160 lines 0 comments Download
D content/shell/renderer/test_runner/TestPlugin.cpp View 1 1 chunk +0 lines, -683 lines 0 comments Download
A content/shell/renderer/test_runner/test_plugin.h View 1 chunk +175 lines, -0 lines 0 comments Download
A content/shell/renderer/test_runner/test_plugin.cc View 1 1 chunk +763 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.cc View 1 2 3 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Abhishek
PTAL !
6 years, 4 months ago (2014-08-15 19:45:42 UTC) #1
jochen (gone - plz use gerrit)
lgtm, thanks
6 years, 3 months ago (2014-09-02 10:23:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abhishek.a21@samsung.com/469943003/1
6 years, 3 months ago (2014-09-02 10:26:10 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-09-02 10:37:21 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/10997) ios_rel_device on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/builds/10944) ios_rel_device_ninja ...
6 years, 3 months ago (2014-09-02 10:39:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abhishek.a21@samsung.com/469943003/20001
6 years, 3 months ago (2014-09-03 13:18:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abhishek.a21@samsung.com/469943003/40001
6 years, 3 months ago (2014-09-03 14:49:51 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 3 months ago (2014-09-03 16:46:58 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001) as e273363df93b86648d601ef7069be1b97e641801
6 years, 3 months ago (2014-09-03 17:22:19 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:26:32 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/dd9554f3fb936060ee3db0912b1ada9bf33e2c60
Cr-Commit-Position: refs/heads/master@{#293160}

Powered by Google App Engine
This is Rietveld 408576698