Issue 469943002: Check the Argument to the Catch Function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 469943002: Check the Argument to the Catch Function (Closed)

Created:
6 years, 4 months ago by robliao

Modified:
6 years, 4 months ago

Reviewers:
xiyuan

CC:
chromium-reviews, arv+watch_chromium.org, skare_, rgustafson

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Check the Argument to the Catch Function Due to promise chaining, the rejecting promise may not necessarily be the topmost method returning the promise. In this specific case, getAuth() is chained in by requestFromServer, and getAuth can reject with no arguments. The fix here is to ensure the argument is always an object. BUG=402729 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289668