Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 469923002: Add missing calls to ScriptWrappable::init in FontFace, LocalCredential and FederatedCredential. (Closed)

Created:
6 years, 4 months ago by rmacnak
Modified:
4 years, 7 months ago
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Project:
blink
Visibility:
Public.

Description

Add missing calls to ScriptWrappable::init in FontFace, LocalCredential and FederatedCredential. Their absence tripped stronger asserts in multivm's refactoring of ScriptWrappable. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180230

Patch Set 1 #

Patch Set 2 : + LocalCredential #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M Source/core/css/FontFace.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/credentialmanager/FederatedCredential.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/credentialmanager/LocalCredential.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
rmacnak
6 years, 4 months ago (2014-08-13 22:32:50 UTC) #1
haraken
LGTM I wonder why the code has been working without having these ScriptWrappable::init...
6 years, 4 months ago (2014-08-13 23:23:15 UTC) #2
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 4 months ago (2014-08-13 23:23:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmacnak@google.com/469923002/20001
6 years, 4 months ago (2014-08-13 23:24:33 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 03:58:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (20001) as 180230

Powered by Google App Engine
This is Rietveld 408576698