Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 469913002: Rename CollectionIndexCache API to not use 'Element' (Closed)

Created:
6 years, 4 months ago by Inactive
Modified:
6 years, 4 months ago
Reviewers:
adamk, rwlbuis
CC:
blink-reviews, blink-reviews-html_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, rwlbuis
Project:
blink
Visibility:
Public.

Description

Rename CollectionIndexCache API to not use 'Element' Rename CollectionIndexCache API to not use 'Element': - traverseToFirstElement() -> traverseToFirst() - traverseToLastElement() -> traverseToLast() Using Element is confusing because some CollectionIndexCache users like ChildNodeList deal with pure Nodes. The Node type is a template parameter of the CollectionIndexCache class so the API should be seem to be Element specific. R=rob.buis@samsung.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180371

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M Source/core/dom/ChildNodeList.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/LiveNodeList.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/LiveNodeList.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/CollectionIndexCache.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLCollection.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLCollection.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Inactive
Let me know if you have a better naming suggestion.
6 years, 4 months ago (2014-08-13 22:55:55 UTC) #1
rwlbuis
lgtm
6 years, 4 months ago (2014-08-15 15:10:26 UTC) #2
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 4 months ago (2014-08-15 15:11:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/469913002/1
6 years, 4 months ago (2014-08-15 15:13:39 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-15 15:14:09 UTC) #5
commit-bot: I haz the power
Failed to apply patch for Source/core/dom/LiveNodeList.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 4 months ago (2014-08-15 15:14:10 UTC) #6
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 4 months ago (2014-08-15 15:17:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/469913002/20001
6 years, 4 months ago (2014-08-15 15:18:48 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 16:17:17 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (20001) as 180371

Powered by Google App Engine
This is Rietveld 408576698