Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Unified Diff: sdk/lib/_internal/compiler/implementation/dump_info.dart

Issue 469903002: Added a test for dump-info with lots of closures. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: rename variables to make the test easier to read Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/dump_info.dart
diff --git a/sdk/lib/_internal/compiler/implementation/dump_info.dart b/sdk/lib/_internal/compiler/implementation/dump_info.dart
index a5e52e54a15dcda0ba69281699a638c3124b8125..f2c0b758755bdac4b122f6da880a0b94af2f42ba 100644
--- a/sdk/lib/_internal/compiler/implementation/dump_info.dart
+++ b/sdk/lib/_internal/compiler/implementation/dump_info.dart
@@ -192,9 +192,9 @@ class ElementToJsonVisitor extends ElementVisitor<Map<String, dynamic>> {
List<String> children = [];
StringBuffer emittedCode = compiler.dumpInfoTask.codeOf(element);
- // If a field has an empty inferred type it is never used.
TypeMask inferredType =
compiler.typesTask.getGuaranteedTypeOfElement(element);
sra1 2014/08/13 21:45:26 indent by +4 when breaking an expression
Ty Overby (Google) 2014/08/13 22:00:31 Done.
+ // If a field has an empty inferred type it is never used.
if (inferredType == null || inferredType.isEmpty || element.isConst) {
return null;
}

Powered by Google App Engine
This is Rietveld 408576698