Added a test for dump-info with lots of closures.

tests/compiler/dart2js/dump_info_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 // Test that parameters keep their names in the output.
 
 import "package:expect/expect.dart";
 import "package:async_helper/async_helper.dart";
 import 'memory_compiler.dart';
 import 'package:compiler/implementation/dump_info.dart';
 import 'dart:convert';
@@ skipping 24 matching lines @@
   a = 3;
 }
 
 main() {
   print(a);
   f();
   print(new c(2).foo());
 }
 """;
 
+const String TEST_TWO = r"""
 main() {
-  var compiler = compilerFor({'main.dart': TEST_ONE}, options: ["--dump-info"]);
-  asyncTest(() => compiler.runCompiler(Uri.parse('memory:main.dart')).then((_) {
-    var dumpTask = compiler.dumpInfoTask;
-    dumpTask.collectInfo();
-    var info = dumpTask.infoCollector;
+  print(bar);
+  print(bar());
+  print(new X().foo);
+  print(new X().foo());
+}
 
-    StringBuffer sb = new StringBuffer();
-    dumpTask.dumpInfoJson(sb);
-    String json = sb.toString();
-    Map<String, dynamic> map = JSON.decode(json);
-    Expect.isTrue(map.isNotEmpty);
+bar() => [() => [() => [() => [() => [() => [() => [() => [() => [() => [() =>
+[() => []]]]]]]]]]]];
+
+class X {
+  foo() => [() => [() => [() => [() => [() => [() => [() => [() => [() =>
+[() => []]]]]]]]]]];
+}
+""";
+
+typedef void JsonTaking(Map<String, dynamic> json);

[sra1, 2014/08/13 21:45:26]

I'd put a line between top level declarations unless they are all single-line
related constants.

[Ty Overby (Google), 2014/08/13 22:00:31]

Done.

+void jsonTest(String program, JsonTaking testFn) {
+  var compiler = compilerFor({'main.dart': program}, options: ['--dump-info']);
+  asyncTest(() => compiler.runCompiler(Uri.parse('memory:main.dart')).then(
+    (_) {
+      var dumpTask = compiler.dumpInfoTask;
+      dumpTask.collectInfo();
+      var info = dumpTask.infoCollector;
+
+      StringBuffer sb = new StringBuffer();
+      dumpTask.dumpInfoJson(sb);
+      String json = sb.toString();
+      Map<String, dynamic> map = JSON.decode(json);
+
+      testFn(map);
+    }));
+}
+
+main() {
+  jsonTest(TEST_ONE, (map) {
     Expect.isTrue(map['elements'].isNotEmpty);
     Expect.isTrue(map['elements']['function'].isNotEmpty);
     Expect.isTrue(map['elements']['library'].isNotEmpty);
 
     Expect.isTrue(map['elements']['library'].values.any((lib) {
       return lib['name'] == "main";
     }));
     Expect.isTrue(map['elements']['class'].values.any((clazz) {
       return clazz['name'] == "c";
     }));
     Expect.isTrue(map['elements']['function'].values.any((fun) {
       return fun['name'] == 'f';
     }));
-  }));
+  });
+
+  jsonTest(TEST_TWO, (map) {
+    var functions = map['elements']['function'].values;
+    Expect.isTrue(functions.any((fn) {
+      return fn['name'] == 'bar' && fn['children'].length == 11;
+    }));
+    Expect.isTrue(functions.any((fn) {
+      return fn['name'] == 'foo' && fn['children'].length == 10;
+    }));
+  });
 }