Issue 469863002: Allow the Chrome Web Store to use chrome.system.* apis

Issue 469863002: Allow the Chrome Web Store to use chrome.system.* apis (Closed)

Created:
6 years, 4 months ago by Devlin

Modified:
6 years, 4 months ago

Reviewers:
Yoyo Zhou

CC:
chromium-reviews, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Allow the Chrome Web Store to use chrome.system.* apis BUG=403338 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289585

Patch Set 1 : #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -21 lines)			Patch
	M	chrome/browser/resources/webstore_app/manifest.json	View		1 chunk	+6 lines, -1 line	0 comments	Download
	M	chrome/common/extensions/api/_permission_features.json	View		1 chunk	+55 lines, -20 lines	1 comment	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Devlin

Hey Yoyo, webstore's pushing for this before branch, so a quick review would be appreciated. ...

6 years, 4 months ago (2014-08-13 19:26:22 UTC) #1

Yoyo Zhou

LGTM https://chromiumcodereview.appspot.com/469863002/diff/20001/chrome/common/extensions/api/_permission_features.json File chrome/common/extensions/api/_permission_features.json (right): https://chromiumcodereview.appspot.com/469863002/diff/20001/chrome/common/extensions/api/_permission_features.json#newcode1010 chrome/common/extensions/api/_permission_features.json:1010: "system.cpu": [ I think it should be possible ...

6 years, 4 months ago (2014-08-13 20:24:09 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/469863002/20001

6 years, 4 months ago (2014-08-13 20:28:08 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...

6 years, 4 months ago (2014-08-14 02:30:33 UTC) #5

commit-bot: I haz the power

6 years, 4 months ago (2014-08-14 15:11:27 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (20001) as 289585

Expand Messages | Collapse Messages