Mojo: simple iframe support.

Mojo: simple iframe support.

BUG=394644
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290098

[Matt Perry, 2014-08-14 23:21:46]

This gets us a step closer to Gmail loading. The frames are not hooked up to the
view manager, but I'm unclear on what that would achieve. The frame hierarchy is
rooted at the WebView, which draws the whole thing - we can't independently
draw/manage the subframes, AFAICT.

Also, the code ordering is funky which should make it easier to see changes. I
can move SimpleFrameClient.

[darin (slow to review), 2014-08-14 23:33:42]

On 2014/08/14 23:21:46, Matt Perry wrote:
> This gets us a step closer to Gmail loading. The frames are not hooked up to
the
> view manager, but I'm unclear on what that would achieve. The frame hierarchy
is
> rooted at the WebView, which draws the whole thing - we can't independently
> draw/manage the subframes, AFAICT.

Hooking frames up to the View Manager is orthogonal to getting Gmail loading.
That is about enabling site-isolation, so that the sandbox around an HTMLViewer
can be origin restricted. For now, just letting Blink manage all of the frames
seems fine to me.

[darin (slow to review), 2014-08-14 23:45:52]

https://codereview.chromium.org/469803005/diff/1/mojo/services/html_viewer/ht...
File mojo/services/html_viewer/html_document_view.cc (right):

https://codereview.chromium.org/469803005/diff/1/mojo/services/html_viewer/ht...
mojo/services/html_viewer/html_document_view.cc:165:
blink::WebLocalFrame::create(new SimpleFrameClient(service_provider_,
why do you need a new WebFrameClient instance per frame? i guess this is with an
eye toward using the View system for each Frame?

https://codereview.chromium.org/469803005/diff/1/mojo/services/html_viewer/ht...
File mojo/services/html_viewer/html_document_view.h (right):

https://codereview.chromium.org/469803005/diff/1/mojo/services/html_viewer/ht...
mojo/services/html_viewer/html_document_view.h:57: public SimpleFrameClient,
perhaps it would be better to use composition here? agreed that it makes sense
to pull SimpleFrameClient out into its own file.

[Matt Perry, 2014-08-15 00:40:04]

https://codereview.chromium.org/469803005/diff/1/mojo/services/html_viewer/ht...
File mojo/services/html_viewer/html_document_view.cc (right):

https://codereview.chromium.org/469803005/diff/1/mojo/services/html_viewer/ht...
mojo/services/html_viewer/html_document_view.cc:165:
blink::WebLocalFrame::create(new SimpleFrameClient(service_provider_,
On 2014/08/14 23:45:52, darin wrote:
> why do you need a new WebFrameClient instance per frame? i guess this is with
an
> eye toward using the View system for each Frame?

Doh. I guess you don't. I assumed WebLocalFrame expected a separate client
instance. I'll go the much simpler route and reuse the same client.

[darin (slow to review), 2014-08-15 03:26:53]

LGTM

https://codereview.chromium.org/469803005/diff/20001/mojo/services/html_viewe...
File mojo/services/html_viewer/html_document_view.cc (right):

https://codereview.chromium.org/469803005/diff/20001/mojo/services/html_viewe...
mojo/services/html_viewer/html_document_view.cc:156: void
HTMLDocumentView::didDisownOpener(blink::WebLocalFrame* frame) {
I suppose these empty methods don't really need to be overridden at this point?

[Matt Perry, 2014-08-15 19:08:13]

The CQ bit was checked by mpcomplete@chromium.org

[commit-bot: I haz the power, 2014-08-15 19:09:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/469803005/40001

[commit-bot: I haz the power, 2014-08-16 00:18:22]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[commit-bot: I haz the power, 2014-08-16 05:52:00]

Committed patchset #3 (40001) as 290098