Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 469773002: Cleanup blink:: prefix usage in Source/core/modules/[mediasource/*.cpp to websockets/*.cpp] (Closed)

Created:
6 years, 4 months ago by Sunil Ratnu
Modified:
6 years, 4 months ago
Reviewers:
tkent, abarth-chromium
CC:
blink-reviews, eric.carlson_apple.com, falken, feature-media-reviews_chromium.org, gyuyoung.kim_webkit.org, horo+watch_chromium.org, jsbell+serviceworker_chromium.org, kinuko+fileapi, kinuko+serviceworker, michaeln, mvanouwerkerk+watch_chromium.org, nhiroki, philipj_slow, Raymond Toy, serviceworker-reviews, tommyw+watchlist_chromium.org, tyoshino+watch_chromium.org, tzik, yhirano+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Cleanup blink:: prefix usage in Source/core/modules/[mediasource/*.cpp to websockets/*.cpp] Cleanup blink:: prefix usage in Source/core/modules/[mediasource/*.cpp to websockets/*.cpp] - Merge multiple |namespace blink {}| blocks - Remove unnecessary blink:: prefixes - Make blank lines consistent BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180201

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+275 lines, -273 lines) Patch
M Source/modules/mediasource/HTMLVideoElementMediaSource.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/mediasource/MediaSource.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/mediastream/MediaConstraintsImpl.cpp View 5 chunks +13 lines, -12 lines 0 comments Download
M Source/modules/mediastream/MediaDeviceInfo.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/modules/mediastream/MediaStreamTrackSourcesRequestImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/RTCDTMFSender.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/mediastream/RTCDataChannel.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/modules/mediastream/RTCIceCandidate.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/mediastream/RTCPeerConnection.cpp View 14 chunks +14 lines, -14 lines 0 comments Download
M Source/modules/mediastream/RTCSessionDescription.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/mediastream/RTCSessionDescriptionRequestImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/SourceInfo.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
M Source/modules/mediastream/UserMediaRequest.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M Source/modules/navigatorcontentutils/testing/NavigatorContentUtilsClientMock.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/modules/netinfo/NetworkInformation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/push_messaging/PushController.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/push_messaging/PushError.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/push_messaging/PushManager.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/quota/DeprecatedStorageQuota.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/modules/quota/DeprecatedStorageQuotaCallbacksImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/quota/StorageQuota.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/modules/quota/StorageQuotaCallbacksImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/screen_orientation/LockOrientationCallback.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/modules/screen_orientation/ScreenOrientation.cpp View 4 chunks +14 lines, -14 lines 0 comments Download
M Source/modules/screen_orientation/ScreenOrientationController.cpp View 5 chunks +13 lines, -13 lines 0 comments Download
M Source/modules/screen_orientation/ScreenOrientationDispatcher.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/CacheStorage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/Client.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/FetchManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/FetchRequestData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/FetchResponseData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/Request.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/Response.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorker.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainerClient.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerError.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/serviceworkers/WaitUntilObserver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/vibration/NavigatorVibration.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/webaudio/AsyncAudioDecoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/ScriptProcessorNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseBackendBase.cpp View 6 chunks +12 lines, -12 lines 0 comments Download
M Source/modules/webdatabase/DatabaseThread.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseTracker.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/modules/webdatabase/QuotaTracker.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/webdatabase/SQLTransactionClient.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/webmidi/MIDIAccessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/websockets/NewWebSocketChannelImpl.cpp View 7 chunks +8 lines, -8 lines 0 comments Download
M Source/modules/websockets/NewWebSocketChannelImplTest.cpp View 33 chunks +70 lines, -70 lines 0 comments Download
M Source/modules/websockets/WebSocketHandshake.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/websockets/WebSocketPerMessageDeflate.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/websockets/WorkerThreadableWebSocketChannel.cpp View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Sunil Ratnu
Please review this. Thanks!
6 years, 4 months ago (2014-08-13 15:31:52 UTC) #1
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 4 months ago (2014-08-13 16:33:17 UTC) #2
abarth-chromium
lgtm
6 years, 4 months ago (2014-08-13 16:33:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/469773002/1
6 years, 4 months ago (2014-08-13 16:34:24 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-13 18:32:35 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 19:41:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (1) as 180201

Powered by Google App Engine
This is Rietveld 408576698