Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(903)

Issue 469763002: Revert of Run pkg-config for Udev only if use_udev==1 (Closed)

Created:
6 years, 4 months ago by dnicoara
Modified:
6 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Revert of Run pkg-config for Udev only if use_udev==1 (patchset #1 of https://codereview.chromium.org/429723002/) Reason for revert: Breaks builds where use_udev==0 since certain targets just assume udev and never check against use_udev. Udev package should be wrapped in a use_udev confitional altogether and all the locations using Udev should check against use_udev. Original issue's description: > Run pkg-config for Udev only if use_udev==1 > > Some embedded platforms do not have udev support. The change will skip > running pkg-config if use_udev=0. > > BUG=none > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288770 TBR=brettw@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289280

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M build/config/linux/BUILD.gn View 1 chunk +2 lines, -4 lines 0 comments Download
M build/linux/system.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
dnicoara
Created Revert of Run pkg-config for Udev only if use_udev==1
6 years, 4 months ago (2014-08-13 13:44:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/469763002/1
6 years, 4 months ago (2014-08-13 13:45:24 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-13 13:45:25 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-13 13:45:26 UTC) #4
dnicoara
The CQ bit was checked by dnicoara@chromium.org
6 years, 4 months ago (2014-08-13 13:48:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/469763002/1
6 years, 4 months ago (2014-08-13 13:49:13 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 13:50:23 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (1) as 289280

Powered by Google App Engine
This is Rietveld 408576698