Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(949)

Issue 46973005: Media Galleries: Use the same last directory entry as file_system_api. (Closed)

Created:
7 years, 1 month ago by Lei Zhang
Modified:
7 years, 1 month ago
CC:
chromium-reviews, Lei Zhang, tommycli, Greg Billock, vandebo (ex-Chrome)
Visibility:
Public.

Description

Media Galleries: Use the same last directory entry as file_system_api. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232958

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -4 lines) Patch
M chrome/browser/media_galleries/media_galleries_dialog_controller.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/media_galleries/media_galleries_dialog_controller.cc View 5 chunks +18 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Lei Zhang
What do you guys think about re-using file_system_api::GetLastChooseEntryDirectory() here? Also, do we want file_system_api to ...
7 years, 1 month ago (2013-11-03 07:28:53 UTC) #1
benwells
On 2013/11/03 07:28:53, Lei Zhang wrote: > What do you guys think about re-using > ...
7 years, 1 month ago (2013-11-04 02:20:38 UTC) #2
Greg Billock
lgtm
7 years, 1 month ago (2013-11-04 16:35:57 UTC) #3
vandebo (ex-Chrome)
LGTM
7 years, 1 month ago (2013-11-04 17:09:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/46973005/1
7 years, 1 month ago (2013-11-04 17:57:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/46973005/1
7 years, 1 month ago (2013-11-04 21:34:55 UTC) #6
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) ui_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=98715
7 years, 1 month ago (2013-11-04 23:22:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/46973005/1
7 years, 1 month ago (2013-11-05 00:20:33 UTC) #8
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 1 month ago (2013-11-05 02:33:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/46973005/1
7 years, 1 month ago (2013-11-05 05:12:49 UTC) #10
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=184905
7 years, 1 month ago (2013-11-05 07:50:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/46973005/1
7 years, 1 month ago (2013-11-05 08:12:24 UTC) #12
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 13:35:26 UTC) #13
Message was sent while issue was closed.
Change committed as 232958

Powered by Google App Engine
This is Rietveld 408576698