Issue 469693003: Cleanup: Remove getSmartClipData function from WebView API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 469693003: Cleanup: Remove getSmartClipData function from WebView API. (Closed)

Created:
6 years, 4 months ago by tfarina

Modified:
6 years, 4 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, blink-reviews, Changwan Ryu, dglazkov+blink, jamesr

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Cleanup: Remove getSmartClipData function from WebView API. This function is only implemented by blink_web, but not called by anyone, anywhere. There are not callers of it on Blink nor on Chromium. This fixes the TODO in WebView.h BUG=None TEST=None R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180138

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -13 lines)			Patch
M	Source/web/WebViewImpl.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/web/WebViewImpl.cpp	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	public/web/WebView.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/469693003/1

6 years, 4 months ago (2014-08-13 04:51:36 UTC) #4

Message was sent while issue was closed.

Change committed as 180138

Expand Messages | Collapse Messages