Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 469673004: DevTools: show target's selector for old timeline (Closed)

Created:
6 years, 4 months ago by sergeyv
Modified:
6 years, 4 months ago
Reviewers:
vsevik, yurys, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: show target's selector for old timeline BUG= NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180196

Patch Set 1 #

Patch Set 2 : Rebase on pfeldman's change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M Source/devtools/front_end/timeline/TimelinePanel.js View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
sergeyv
6 years, 4 months ago (2014-08-13 13:18:24 UTC) #1
pfeldman
lgtm
6 years, 4 months ago (2014-08-13 14:46:11 UTC) #2
yurys
lgtm
6 years, 4 months ago (2014-08-13 15:01:15 UTC) #3
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 4 months ago (2014-08-13 15:16:11 UTC) #4
sergeyv
The CQ bit was unchecked by sergeyv@chromium.org
6 years, 4 months ago (2014-08-13 15:16:38 UTC) #5
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 4 months ago (2014-08-13 15:32:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/469673004/40001
6 years, 4 months ago (2014-08-13 15:34:00 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-13 16:42:29 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-13 17:04:10 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/22589)
6 years, 4 months ago (2014-08-13 17:04:12 UTC) #10
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 4 months ago (2014-08-13 17:07:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/469673004/40001
6 years, 4 months ago (2014-08-13 17:08:14 UTC) #12
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 17:08:54 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (40001) as 180196

Powered by Google App Engine
This is Rietveld 408576698