gpu/command_buffer/service/gles2_cmd_decoder_autogen.h - Issue 469673003: Consistently generate INVALID_VALUE on NaN line width

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder_autogen.h

Issue 469673003: Consistently generate INVALID_VALUE on NaN line width (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gpu/command_buffer/service/gles2_cmd_decoder_autogen.h

diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_autogen.h b/gpu/command_buffer/service/gles2_cmd_decoder_autogen.h

index 8011ab19990ac46b82968f7c531f2bb11dd9e6eb..b35899cfbc2797dc67edbabbff8241e3d1e704a0 100644

--- a/gpu/command_buffer/service/gles2_cmd_decoder_autogen.h

+++ b/gpu/command_buffer/service/gles2_cmd_decoder_autogen.h

@@ -1360,7 +1360,7 @@ error::Error GLES2DecoderImpl::HandleLineWidth(

uint32_t immediate_data_size,

const gles2::cmds::LineWidth& c) {

GLfloat width = static_cast<GLfloat>(c.width);

- if (width <= 0.0f) {

+ if (width <= 0.0f || base::IsNaN(width)) {

LOCAL_SET_GL_ERROR(GL_INVALID_VALUE, "LineWidth", "width out of range");

return error::kNoError;

}