Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 469593002: [telemetry] Create BrowserTestCase to reuse the browser for browser_unittest. (Closed)

Created:
6 years, 4 months ago by dtu
Modified:
6 years, 4 months ago
Reviewers:
tonyg, nduca
CC:
chromium-reviews, telemetry+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

[telemetry] Create BrowserTestCase to reuse the browser for browser_unittest. This brings browser_unittest's run time from 21s to 7s on a Z620 Linux, one of our fastest configurations. (We still need 3 browser launches to test browser options and profile loading.) Add BrowserTestCase as the new parent class of TabTestCase. The separation is very clean :) Also add helper method UrlOfUnittestFile - many tests are using http_server.UrlOf incorrectly, and this helper ensures the HTTP server is running and we're pointing to the right file. Also move page_test_test_case from testing/ to unittest/ and remove testing/. BUG=388256 TEST=tools/telemetry/run_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289247

Patch Set 1 : #

Patch Set 2 : Update page_test_test_case references in tools/perf/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -316 lines) Patch
M tools/perf/measurements/loading_trace_unittest.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/rasterize_and_record_micro_unittest.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/record_per_area_unittest.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/repaint_unittest.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/screenshot_unittest.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/skpicture_printer_unittest.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/smoothness_unittest.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/thread_times_unittest.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/tracing_backend_unittest.py View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/browser_unittest.py View 2 chunks +62 lines, -97 lines 0 comments Download
M tools/telemetry/telemetry/core/memory_cache_http_server_unittest.py View 3 chunks +6 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/core/tab_unittest.py View 3 chunks +9 lines, -11 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/navigate_unittest.py View 1 chunk +1 line, -10 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/scroll_unittest.py View 2 chunks +4 lines, -17 lines 0 comments Download
M tools/telemetry/telemetry/page/page_test_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/record_wpr_unittest.py View 1 chunk +1 line, -3 lines 0 comments Download
D tools/telemetry/telemetry/testing/__init__.py View 1 chunk +0 lines, -3 lines 0 comments Download
D tools/telemetry/telemetry/testing/page_test_test_case.py View 1 chunk +0 lines, -111 lines 0 comments Download
A tools/telemetry/telemetry/unittest/browser_test_case.py View 1 chunk +45 lines, -0 lines 0 comments Download
A + tools/telemetry/telemetry/unittest/page_test_test_case.py View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/telemetry/telemetry/unittest/tab_test_case.py View 2 chunks +6 lines, -45 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
dtu
6 years, 4 months ago (2014-08-13 01:54:53 UTC) #1
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 4 months ago (2014-08-13 02:00:44 UTC) #2
tonyg
lgtm
6 years, 4 months ago (2014-08-13 02:00:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/469593002/40001
6 years, 4 months ago (2014-08-13 02:02:50 UTC) #4
nduca
this looks very promising, and is the right route forward. lgtm very much.
6 years, 4 months ago (2014-08-13 03:38:53 UTC) #5
tonyg
CQ failure is legit: ImportError: No module named testing
6 years, 4 months ago (2014-08-13 04:03:44 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-13 05:00:02 UTC) #7
dtu
The CQ bit was checked by dtu@chromium.org
6 years, 4 months ago (2014-08-13 05:00:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/469593002/60001
6 years, 4 months ago (2014-08-13 05:02:57 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 10:06:52 UTC) #10
Message was sent while issue was closed.
Change committed as 289247

Powered by Google App Engine
This is Rietveld 408576698