Issue 469583004: Add dep from mojo_view_manager_bindings to mojo_application_bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 469583004: Add dep from mojo_view_manager_bindings to mojo_application_bindings (Closed)

Created:
6 years, 4 months ago by jamesr

Modified:
6 years, 4 months ago

Reviewers:
viettrungluu

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add dep from mojo_view_manager_bindings to mojo_application_bindings view_manager.mojom imports service_provider.mojom, so the bindings target for view_manager.mojom must depend on the bindings target for service_provider.mojom R=viettrungluu@chromium.org BUG=403719 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289666

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	mojo/mojo_services.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jamesr

6 years, 4 months ago (2014-08-14 19:33:28 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as 289666 (tree was closed).

Expand Messages | Collapse Messages