Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 469573004: Roll harfbuzz to pick up this/NULL comparison fix. (Closed)

Created:
6 years, 4 months ago by Nico
Modified:
6 years, 4 months ago
Reviewers:
behdad_google, behdad
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Roll harfbuzz to pick up this/NULL comparison fix. BUG=403594 TBR=behdad@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290175

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -76 lines) Patch
M third_party/harfbuzz-ng/README.chromium View 2 chunks +5 lines, -2 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-face-private.hh View 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-object-private.hh View 4 chunks +35 lines, -72 lines 1 comment Download
M third_party/harfbuzz-ng/src/hb-set-private.hh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Nico
6 years, 4 months ago (2014-08-17 04:14:37 UTC) #1
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 4 months ago (2014-08-17 04:14:43 UTC) #2
Nico
https://codereview.chromium.org/469573004/diff/1/third_party/harfbuzz-ng/src/hb-object-private.hh File third_party/harfbuzz-ng/src/hb-object-private.hh (right): https://codereview.chromium.org/469573004/diff/1/third_party/harfbuzz-ng/src/hb-object-private.hh#newcode118 third_party/harfbuzz-ng/src/hb-object-private.hh:118: "%s refcount=%d", (looks like someone added tabs here, you ...
6 years, 4 months ago (2014-08-17 04:15:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/469573004/1
6 years, 4 months ago (2014-08-17 04:15:49 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-17 04:15:50 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-17 04:15:51 UTC) #6
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 4 months ago (2014-08-17 04:16:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/469573004/1
6 years, 4 months ago (2014-08-17 04:17:28 UTC) #8
Nico
Committed patchset #1 manually as 290175 (presubmit successful).
6 years, 4 months ago (2014-08-17 05:27:22 UTC) #9
behdad_google
6 years, 4 months ago (2014-08-17 16:48:36 UTC) #10
Message was sent while issue was closed.
lgtm.  my behdad@chromium account os b0rked so I can't review from that one
currently.

Powered by Google App Engine
This is Rietveld 408576698