Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 469573002: Treat null Parent as no Parent for dictionary objects (Closed)

Created:
6 years, 4 months ago by Bo Xu
Modified:
6 years, 4 months ago
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Visibility:
Public.

Description

Treat null Parent as no Parent for dictionary objects To be complient with PDF reference chapter 7.3.7 BUG=402437 R=vitalybuka@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/d38a35e

Patch Set 1 #

Patch Set 2 : Tabify #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M fpdfsdk/src/fpdfppo.cpp View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Bo Xu
Please review this.
6 years, 4 months ago (2014-08-13 00:06:27 UTC) #1
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 4 months ago (2014-08-13 01:01:37 UTC) #2
Bo Xu
6 years, 4 months ago (2014-08-13 02:13:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as d38a35e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698