Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: tools/telemetry/telemetry/unittest/run_tests.py

Issue 469533002: Change gtest launcher to run in parallel and retry failures by default. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: enable parallel jobs by default as well Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/test/launcher/test_launcher.cc ('K') | « base/test/test_switches.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/unittest/run_tests.py
diff --git a/tools/telemetry/telemetry/unittest/run_tests.py b/tools/telemetry/telemetry/unittest/run_tests.py
index ed55b0a1c211ba760be7863ad9109fab71972b27..0a2e3aaedd05c39eac099589b3e3b2d50e57421f 100644
--- a/tools/telemetry/telemetry/unittest/run_tests.py
+++ b/tools/telemetry/telemetry/unittest/run_tests.py
@@ -126,8 +126,8 @@ class RunTestsCommand(command_line.OptparseCommand):
dest='run_disabled_tests',
action='store_true', default=False,
help='Ignore @Disabled and @Enabled restrictions.')
- parser.add_option('--retry-limit', type='int', default=0,
- help='Retry each failure up to N times (default %default)'
+ parser.add_option('--retry-limit', type='int',
+ help='Retry each failure up to N times'
' to de-flake things.')
json_results.AddOptions(parser)
@@ -136,6 +136,11 @@ class RunTestsCommand(command_line.OptparseCommand):
if args.verbosity == 0:
logging.getLogger().setLevel(logging.WARN)
+ # We retry failures by default unless we're running a list of tests
+ # explicitly.
+ if args.retry_limit is None and not args.positional_args:
+ args.retry_limit = 3
+
try:
possible_browser = browser_finder.FindBrowser(args)
except browser_finder.BrowserFinderException, ex:
« base/test/launcher/test_launcher.cc ('K') | « base/test/test_switches.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698