Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 469453003: Cleanup client plugin handling code in the webapp. (Closed)

Created:
6 years, 4 months ago by Sergey Ulanov
Modified:
6 years, 4 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Cleanup client plugin handling code in the webapp. Previously the <embed> element was created in client_session.js , while it's owned by the ClientPlugin object. Moved plugin creation code where it belongs, to client_plugin.js . R=jamiewalch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289323

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -82 lines) Patch
M remoting/webapp/client_plugin.js View 23 chunks +60 lines, -38 lines 0 comments Download
M remoting/webapp/client_session.js View 5 chunks +5 lines, -44 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Sergey Ulanov
6 years, 4 months ago (2014-08-12 21:24:22 UTC) #1
Jamie
lgtm
6 years, 4 months ago (2014-08-12 21:58:55 UTC) #2
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 4 months ago (2014-08-12 21:59:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/469453003/1
6 years, 4 months ago (2014-08-12 22:03:20 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-13 00:33:33 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-13 02:36:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_triggered_tests/builds/5135)
6 years, 4 months ago (2014-08-13 02:36:46 UTC) #7
Sergey Ulanov
6 years, 4 months ago (2014-08-13 17:00:04 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as 289323 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698