Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1078)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 469423005: Use the non-deprecated way to set the button labels (Closed)

Created:
6 years, 4 months ago by cbiesinger
Modified:
6 years, 4 months ago
Reviewers:
ojan
CC:
ojan, blink-reviews, dsinclair, jochen (gone - plz use gerrit), leviw_travelin_and_unemployed, michaelpg, szager1, teravest
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Use the non-deprecated way to set the button labels Use label="" instead of the textContent R=ojan@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180312

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Tools/GardeningServer/ui/ct-failure-card.html View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
cbiesinger
6 years, 4 months ago (2014-08-15 01:40:05 UTC) #1
ojan
The CQ bit was checked by ojan@chromium.org
6 years, 4 months ago (2014-08-15 01:46:47 UTC) #2
ojan
FYI, you can NOTRY=true these patches. lgtm
6 years, 4 months ago (2014-08-15 01:46:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbiesinger@chromium.org/469423005/1
6 years, 4 months ago (2014-08-15 01:47:30 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 01:48:12 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (1) as 180312

Powered by Google App Engine
This is Rietveld 408576698