NaCl: Send fatal log messages via shared memory.

components/nacl/common/nacl_types.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_NACL_COMMON_NACL_TYPES_H_
 #define COMPONENTS_NACL_COMMON_NACL_TYPES_H_
 
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
+#include "base/memory/shared_memory.h"
 #include "base/process/process_handle.h"
 #include "build/build_config.h"
 #include "ipc/ipc_channel.h"
 #include "ipc/ipc_platform_file.h"
 
 #if defined(OS_POSIX)
 #include "base/file_descriptor_posix.h"
 #endif
 
 #if defined(OS_WIN)
 #include <windows.h>   // for HANDLE
 #endif
 
 // TODO(gregoryd): add a Windows definition for base::FileDescriptor
 namespace nacl {
 
 #if defined(OS_WIN)
 typedef HANDLE FileDescriptor;
 inline HANDLE ToNativeHandle(const FileDescriptor& desc) {
   return desc;
 }
 #elif defined(OS_POSIX)
 typedef base::FileDescriptor FileDescriptor;
 inline int ToNativeHandle(const FileDescriptor& desc) {
   return desc.fd;
 }
 #endif
 
+// We allocate a page of shared memory for sharing crash information between
+// the plugin and the renderer.

[Mark Seaborn, 2014/08/18 19:04:08]

How about: "from trusted code in the NaCl process to the renderer"

This makes the direction explicit.

"Plugin" is ambiguous, so it's better to say "the NaCl process".

[teravest, 2014/08/19 19:58:16]

Done.

+static const int kNaClCrashInfoShmemSize = 4096;
+static const int kNaClCrashInfoMaxLogSize = 1024;
 
 // Parameters sent to the NaCl process when we start it.
 struct NaClStartParams {
   NaClStartParams();
   ~NaClStartParams();
 
   IPC::PlatformFileForTransit nexe_file;
   uint64_t nexe_token_lo;
   uint64_t nexe_token_hi;
 
   std::vector<FileDescriptor> handles;
   FileDescriptor debug_stub_server_bound_socket;
 
   bool validation_cache_enabled;
   std::string validation_cache_key;
   // Chrome version string. Sending the version string over IPC avoids linkage
   // issues in cases where NaCl is not compiled into the main Chromium
   // executable or DLL.
   std::string version;
 
   bool enable_exception_handling;
   bool enable_debug_stub;
   bool enable_ipc_proxy;
   bool uses_irt;
   bool enable_dyncode_syscalls;
 
+  // For plugin <-> renderer crash information reporting.

[Mark Seaborn, 2014/08/18 19:04:09]

"NaCl -> renderer"

[teravest, 2014/08/19 19:58:16]

Done.

+  base::SharedMemoryHandle crash_info_shmem_handle;
+
   // NOTE: Any new fields added here must also be added to the IPC
   // serialization in nacl_messages.h and (for POD fields) the constructor
   // in nacl_types.cc.
 };
 
 // Parameters sent to the browser process to have it launch a NaCl process.
 //
 // If you change this, you will also need to update the IPC serialization in
 // nacl_host_messages.h.
 struct NaClLaunchParams {
@@ skipping 29 matching lines @@
 };
 
 struct NaClLaunchResult {
   NaClLaunchResult();
   NaClLaunchResult(
       FileDescriptor imc_channel_handle,
       const IPC::ChannelHandle& ppapi_ipc_channel_handle,
       const IPC::ChannelHandle& trusted_ipc_channel_handle,
       const IPC::ChannelHandle& manifest_service_ipc_channel_handle,
       base::ProcessId plugin_pid,
-      int plugin_child_id);
+      int plugin_child_id,
+      base::SharedMemoryHandle crash_info_shmem_handle);
   ~NaClLaunchResult();
 
   // For plugin loader <-> renderer IMC communication.
   FileDescriptor imc_channel_handle;
 
   // For plugin <-> renderer PPAPI communication.
   IPC::ChannelHandle ppapi_ipc_channel_handle;
 
   // For plugin loader <-> renderer control communication (loading and
   // starting nexe).
   IPC::ChannelHandle trusted_ipc_channel_handle;
 
   // For plugin <-> renderer ManifestService communication.
   IPC::ChannelHandle manifest_service_ipc_channel_handle;
 
   base::ProcessId plugin_pid;
   int plugin_child_id;
+
+  // For plugin <-> renderer crash information reporting.

[Mark Seaborn, 2014/08/18 19:04:08]

Ditto

[teravest, 2014/08/19 19:58:16]

Done.

+  base::SharedMemoryHandle crash_info_shmem_handle;
 };
 
 }  // namespace nacl
 
 #endif  // COMPONENTS_NACL_COMMON_NACL_TYPES_H_