Fix memory leak of Route newly created notifications to notification provider API

chrome/browser/extensions/api/notifications/notifications_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/notifications/notifications_api.h"
 
 #include "base/callback.h"
 #include "base/guid.h"
 #include "base/rand_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/notifications/desktop_notification_service.h"
 #include "chrome/browser/notifications/desktop_notification_service_factory.h"
 #include "chrome/browser/notifications/notification.h"
+#include "chrome/browser/notifications/notification_conversion_helper.h"
 #include "chrome/browser/notifications/notification_ui_manager.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/chrome_version_info.h"
 #include "chrome/common/extensions/api/notifications/notification_style.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/web_contents.h"
 #include "extensions/browser/event_router.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/features/feature.h"
@@ skipping 19 matching lines @@
     "Unable to successfully use the provided image.";
 const char kUnexpectedProgressValueForNonProgressType[] =
     "The progress value should not be specified for non-progress notification";
 const char kInvalidProgressValue[] =
     "The progress value should range from 0 to 100";
 const char kExtraListItemsProvided[] =
     "List items provided for notification type != list";
 const char kExtraImageProvided[] =
     "Image resource provided for notification type != image";
 
-// Converts an object with width, height, and data in RGBA format into an
-// gfx::Image (in ARGB format).
-bool NotificationBitmapToGfxImage(
-    float max_scale,
-    const gfx::Size& target_size_dips,
-    api::notifications::NotificationBitmap* notification_bitmap,
-    gfx::Image* return_image) {
-  if (!notification_bitmap)
-    return false;
-
-  const int max_device_pixel_width = target_size_dips.width() * max_scale;
-  const int max_device_pixel_height = target_size_dips.height() * max_scale;
-
-  const int BYTES_PER_PIXEL = 4;
-
-  const int width = notification_bitmap->width;
-  const int height = notification_bitmap->height;
-
-  if (width < 0 || height < 0 || width > max_device_pixel_width ||
-      height > max_device_pixel_height)
-    return false;
-
-  // Ensure we have rgba data.
-  std::string* rgba_data = notification_bitmap->data.get();
-  if (!rgba_data)
-    return false;
-
-  const size_t rgba_data_length = rgba_data->length();
-  const size_t rgba_area = width * height;
-
-  if (rgba_data_length != rgba_area * BYTES_PER_PIXEL)
-    return false;
-
-  SkBitmap bitmap;
-  // Allocate the actual backing store with the sanitized dimensions.
-  if (!bitmap.allocN32Pixels(width, height))
-    return false;
-
-  // Ensure that our bitmap and our data now refer to the same number of pixels.
-  if (rgba_data_length != bitmap.getSafeSize())
-    return false;
-
-  uint32_t* pixels = bitmap.getAddr32(0, 0);
-  const char* c_rgba_data = rgba_data->data();
-
-  for (size_t t = 0; t < rgba_area; ++t) {
-    // |c_rgba_data| is RGBA, pixels is ARGB.
-    size_t rgba_index = t * BYTES_PER_PIXEL;
-    pixels[t] = SkPreMultiplyColor(
-        ((c_rgba_data[rgba_index + 3] & 0xFF) << 24) |
-        ((c_rgba_data[rgba_index + 0] & 0xFF) << 16) |
-        ((c_rgba_data[rgba_index + 1] & 0xFF) << 8) |
-        ((c_rgba_data[rgba_index + 2] & 0xFF) << 0));
-  }
-
-  // TODO(dewittj): Handle HiDPI images with more than one scale factor
-  // representation.
-  gfx::ImageSkia skia(gfx::ImageSkiaRep(bitmap, 1.0f));
-  *return_image = gfx::Image(skia);
-  return true;
-}
-
 // Given an extension id and another id, returns an id that is unique
 // relative to other extensions.
 std::string CreateScopedIdentifier(const std::string& extension_id,
                                    const std::string& id) {
   return extension_id + "-" + id;
 }
 
 // Removes the unique internal identifier to send the ID as the
 // extension expects it.
 std::string StripScopeFromIdentifier(const std::string& extension_id,
@@ skipping 140 matching lines @@
   float image_scale =
       ui::GetScaleForScaleFactor(ui::GetSupportedScaleFactors().back());
 
   // Extract required fields: type, title, message, and icon.
   message_center::NotificationType type =
       MapApiTemplateTypeToType(options->type);
   const base::string16 title(base::UTF8ToUTF16(*options->title));
   const base::string16 message(base::UTF8ToUTF16(*options->message));
   gfx::Image icon;
 
-  if (!NotificationBitmapToGfxImage(image_scale,
-                                    bitmap_sizes.icon_size,
-                                    options->icon_bitmap.get(),
-                                    &icon)) {
+  if (!NotificationConversionHelper::NotificationBitmapToGfxImage(
+          image_scale,
+          bitmap_sizes.icon_size,
+          options->icon_bitmap.get(),
+          &icon)) {
     SetError(kUnableToDecodeIconError);
     return false;
   }
 
   // Then, handle any optional data that's been provided.
   message_center::RichNotificationData optional_fields;
   if (options->app_icon_mask_url.get()) {
-    if (!NotificationBitmapToGfxImage(image_scale,
-                                      bitmap_sizes.app_icon_mask_size,
-                                      options->app_icon_mask_bitmap.get(),
-                                      &optional_fields.small_image)) {
+    if (!NotificationConversionHelper::NotificationBitmapToGfxImage(
+            image_scale,
+            bitmap_sizes.app_icon_mask_size,
+            options->app_icon_mask_bitmap.get(),
+            &optional_fields.small_image)) {
       SetError(kUnableToDecodeIconError);
       return false;
     }
   }
 
   if (options->priority.get())
     optional_fields.priority = *options->priority;
 
   if (options->event_time.get())
     optional_fields.timestamp = base::Time::FromJsTime(*options->event_time);
 
   if (options->buttons.get()) {
     // Currently we allow up to 2 buttons.
     size_t number_of_buttons = options->buttons->size();
     number_of_buttons = number_of_buttons > 2 ? 2 : number_of_buttons;
 
     for (size_t i = 0; i < number_of_buttons; i++) {
       message_center::ButtonInfo info(
           base::UTF8ToUTF16((*options->buttons)[i]->title));
-      NotificationBitmapToGfxImage(image_scale,
-                                   bitmap_sizes.button_icon_size,
-                                   (*options->buttons)[i]->icon_bitmap.get(),
-                                   &info.icon);
+      NotificationConversionHelper::NotificationBitmapToGfxImage(
+          image_scale,
+          bitmap_sizes.button_icon_size,
+          (*options->buttons)[i]->icon_bitmap.get(),
+          &info.icon);
       optional_fields.buttons.push_back(info);
     }
   }
 
   if (options->context_message) {
     optional_fields.context_message =
         base::UTF8ToUTF16(*options->context_message);
   }
 
-  bool has_image = NotificationBitmapToGfxImage(image_scale,
-                                                bitmap_sizes.image_size,
-                                                options->image_bitmap.get(),
-                                                &optional_fields.image);
+  bool has_image = NotificationConversionHelper::NotificationBitmapToGfxImage(
+      image_scale,
+      bitmap_sizes.image_size,
+      options->image_bitmap.get(),
+      &optional_fields.image);
   // We should have an image if and only if the type is an image type.
   if (has_image != (type == message_center::NOTIFICATION_TYPE_IMAGE)) {
     SetError(kExtraImageProvided);
     return false;
   }
 
   // We should have list items if and only if the type is a multiple type.
   bool has_list_items = options->items.get() && options->items->size() > 0;
   if (has_list_items != (type == message_center::NOTIFICATION_TYPE_MULTIPLE)) {
     SetError(kExtraListItemsProvided);
@@ skipping 61 matching lines @@
   if (options->type != api::notifications::TEMPLATE_TYPE_NONE)
     notification->set_type(MapApiTemplateTypeToType(options->type));
   if (options->title)
     notification->set_title(base::UTF8ToUTF16(*options->title));
   if (options->message)
     notification->set_message(base::UTF8ToUTF16(*options->message));
 
   // TODO(dewittj): Return error if this fails.
   if (options->icon_bitmap) {
     gfx::Image icon;
-    NotificationBitmapToGfxImage(
+    NotificationConversionHelper::NotificationBitmapToGfxImage(
         image_scale, bitmap_sizes.icon_size, options->icon_bitmap.get(), &icon);
     notification->set_icon(icon);
   }
 
   gfx::Image app_icon_mask;
-  if (NotificationBitmapToGfxImage(image_scale,
-                                   bitmap_sizes.app_icon_mask_size,
-                                   options->app_icon_mask_bitmap.get(),
-                                   &app_icon_mask)) {
+  if (NotificationConversionHelper::NotificationBitmapToGfxImage(
+          image_scale,
+          bitmap_sizes.app_icon_mask_size,
+          options->app_icon_mask_bitmap.get(),
+          &app_icon_mask)) {
     notification->set_small_image(app_icon_mask);
   }
 
   if (options->priority)
     notification->set_priority(*options->priority);
 
   if (options->event_time)
     notification->set_timestamp(base::Time::FromJsTime(*options->event_time));
 
   if (options->buttons) {
     // Currently we allow up to 2 buttons.
     size_t number_of_buttons = options->buttons->size();
     number_of_buttons = number_of_buttons > 2 ? 2 : number_of_buttons;
 
     std::vector<message_center::ButtonInfo> buttons;
     for (size_t i = 0; i < number_of_buttons; i++) {
       message_center::ButtonInfo button(
           base::UTF8ToUTF16((*options->buttons)[i]->title));
-      NotificationBitmapToGfxImage(image_scale,
-                                   bitmap_sizes.button_icon_size,
-                                   (*options->buttons)[i]->icon_bitmap.get(),
-                                   &button.icon);
+      NotificationConversionHelper::NotificationBitmapToGfxImage(
+          image_scale,
+          bitmap_sizes.button_icon_size,
+          (*options->buttons)[i]->icon_bitmap.get(),
+          &button.icon);
       buttons.push_back(button);
     }
     notification->set_buttons(buttons);
   }
 
   if (options->context_message) {
     notification->set_context_message(
         base::UTF8ToUTF16(*options->context_message));
   }
 
   gfx::Image image;
-  bool has_image = NotificationBitmapToGfxImage(image_scale,
-                                                bitmap_sizes.image_size,
-                                                options->image_bitmap.get(),
-                                                &image);
+  bool has_image = NotificationConversionHelper::NotificationBitmapToGfxImage(
+      image_scale,
+      bitmap_sizes.image_size,
+      options->image_bitmap.get(),
+      &image);
   if (has_image) {
     // We should have an image if and only if the type is an image type.
     if (notification->type() != message_center::NOTIFICATION_TYPE_IMAGE) {
       SetError(kExtraImageProvided);
       return false;
     }
     notification->set_image(image);
   }
 
   if (options->progress) {
@@ skipping 217 matching lines @@
           ? api::notifications::PERMISSION_LEVEL_GRANTED
           : api::notifications::PERMISSION_LEVEL_DENIED;
 
   SetResult(new base::StringValue(api::notifications::ToString(result)));
   SendResponse(true);
 
   return true;
 }
 
 }  // namespace extensions