Issue 469393007: Fix == operator in GrTextureDomain so we don't compair uninitilized values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 469393007: Fix == operator in GrTextureDomain so we don't compair uninitilized values (Closed)

Created:
6 years, 4 months ago by egdaniel

Modified:
6 years, 4 months ago

Reviewers:
bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Fix == operator in GrTextureDomain so we don't compair uninitilized values We were getting random behavior when comparing two GrTexureDomains since fDomain was not initialized when the mode was set to ignore. BUG=skia: Committed: https://skia.googlesource.com/skia/+/01a492f959e886f89995c6d1bbcd9f7bb7639726

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/gpu/effects/GrTextureDomain.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/egdaniel@google.com/469393007/1

6 years, 4 months ago (2014-08-21 13:36:40 UTC) #5

commit-bot: I haz the power

6 years, 4 months ago (2014-08-21 13:47:55 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (1) as 01a492f959e886f89995c6d1bbcd9f7bb7639726

Expand Messages | Collapse Messages